[refactor] Cleanup minor nits #221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregnazario
requested review from
0xmaayan,
0xmigo,
heliuchuan and
a team
as code owners
There were async functions that were being set to non-async functions then being awaited. That was very confusing, and this fixes it
gregnazario
force-pushed
the
cleanup-minor-nits
branch
from
c60b72f to
434c0f5
Compare
|
Closing will, come back with another pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This cleans up grammar, spellchecks, and style that was picked up automatically by the IDE. Additionally, fix the docs page, and remove duplicate constants.
Test Plan
pnpm testThis actually pointed out that some test were improperly awaiting on something that wasn't supposed to be async (but it was).Additionally, found some other issues in tests that caused failures due to not waiting on the indexer to catch up.
Related Links