Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add your_coin example #208

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Add your_coin example #208

merged 3 commits into from
Nov 28, 2023

Conversation

0xmaayan
Copy link
Collaborator

Description

This PR

Test Plan

pnpm test

Related Links

Copy link
Collaborator

@gregnazario gregnazario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback on toString(), but otherwise it's good

examples/typescript/utils.ts Outdated Show resolved Hide resolved
examples/typescript/yourCoin/index.ts Outdated Show resolved Hide resolved
examples/typescript/yourCoin/index.ts Outdated Show resolved Hide resolved
examples/typescript/yourCoin/moonCoin/moonCoin.json Outdated Show resolved Hide resolved
src/api/account.ts Show resolved Hide resolved
src/api/account.ts Outdated Show resolved Hide resolved
src/api/account.ts Outdated Show resolved Hide resolved
},
});

return data[0] ? data[0].amount : 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return data[0] ? data[0].amount : 0;
return data[0]?.amount ?? 0;

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesnt work with cjs

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really? Interesting...

tests/e2e/api/account.test.ts Outdated Show resolved Hide resolved
@0xmaayan 0xmaayan enabled auto-merge (squash) November 28, 2023 16:16
@0xmaayan 0xmaayan merged commit b7e03dc into main Nov 28, 2023
10 checks passed
@0xmaayan 0xmaayan deleted the your_coin_example branch November 28, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants