-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consolidate move struct and resource type #120
Conversation
I think |
@xbtmatt Yeah I was thinking about using a alias option that I mentioned in the description. Not sure if that will confuse the user though. |
Let's not use alias, that only creates confusion. We should go with a type name that makes sense to us |
src/types/index.ts
Outdated
@@ -667,7 +667,6 @@ export type MoveUint128Type = string; | |||
export type MoveUint256Type = string; | |||
export type MoveAddressType = string; | |||
export type MoveObjectType = string; | |||
export type MoveStructType = `${string}::${string}::${string}`; | |||
export type MoveOptionType = MoveType | null | undefined; | |||
/** | |||
* String representation of a on-chain Move struct type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xbtmatt Description will live here. Updating to name MoveStructType
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should say something like...
/**
* This is the format for a fully qualified struct, resource, or entry function in Move.
*/
Above it or something
2ba5f67
to
1562934
Compare
Description
resolve #117
Removing the MoveStructType and consolidate into MoveResourceType.
We could keep both, and assign one to another. i.e
But I feel like it would just confuse the user.
Test Plan
pnpm fmt
Related Links