Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing indexerVersionCheck check var to waitForTransaction in api level #110

Merged
merged 3 commits into from
Oct 25, 2023
Merged

add missing indexerVersionCheck check var to waitForTransaction in api level #110

merged 3 commits into from
Oct 25, 2023

Conversation

0xmigo
Copy link
Contributor

@0xmigo 0xmigo commented Oct 24, 2023

Description

Test Plan

Related Links

0xmaayan
0xmaayan approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@0xmaayan 0xmaayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might worth having it as a custom type

export type WaitForTransactionOptions = {
 timeoutSecs?: number
 checkSuccess?: boolean
 indexerVersionCheck?: boolean
}

gregnazario
gregnazario reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@gregnazario gregnazario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any other functions that need it propagated through? Faucet? Others?

@0xmaayan 0xmaayan mentioned this pull request Oct 24, 2023
Merged
@0xmigo 0xmigo enabled auto-merge (squash) October 25, 2023 16:28
@0xmigo 0xmigo disabled auto-merge October 25, 2023 16:29
@0xmigo 0xmigo enabled auto-merge (squash) October 25, 2023 16:30
@0xmigo 0xmigo merged commit 55f10c7 into main Oct 25, 2023
12 checks passed
@0xmigo 0xmigo deleted the jin/add_missing_indexerSuccessCheck branch October 25, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregnazario gregnazario gregnazario left review comments

@0xmaayan 0xmaayan 0xmaayan approved these changes

@heliuchuan heliuchuan Awaiting requested review from heliuchuan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xmigo @gregnazario @0xmaayan