[Rename] Change arguments
in the transaction builder to functionArguments
, change references in docs
#105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because
arguments
is a reserved keyword in typescript, when you try to use the spread operator with it instrict
mode, it doesn't let you.For example:
The compiler won't let you destructure
args
becausearguments
is reserved. You could of course doarguments: functionArguments
, but perhaps we should just avoid the reserved keyword entirely to avoid issuesI've also changed each instance of
type_arguments
in the docs totypeArguments
I also made sure not to change
arguments
tofunctionArguments
in API calls where the JSON structure is requiredTest Plan