Fix examples #101
Merged
Fix examples #101
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmaayan
requested review from
gregnazario,
0xmigo,
heliuchuan and
a team
as code owners
0xmigo
reviewed
Oct 18, 2023
| @@ -32,7 +32,8 @@ const example = async () => { | |||
| console.log("This example will create two accounts (Alice and Bob), fund them, and transfer between them."); | |||
|
|
|||
| // Setup the client | |||
| const sdk = new aptos.Aptos(); | |||
| const config = new aptos.AptosConfig({ network: aptos.Network.DEVNET }); | |||
There was a problem hiding this comment.
I don't think this is taking in the obj as param anymore? And default is devnet already?
There was a problem hiding this comment.
It does and always is. This is a configuration object.
Yes devnet is default but i think it helps to show the usage of the config option
There was a problem hiding this comment.
ohh I see, so its taking in AptosSettings as an object.
0xmigo
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Plan
Related Links