Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor token v2 models #704

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor token v2 models #704

wants to merge 1 commit into from

Conversation

rtso
Copy link
Collaborator

@rtso rtso commented Feb 4, 2025

  • Move parquet and postgres models into the same common file
  • Remove deprecated tables and queries from postgres processor

Testing

Run tests

@rtso rtso changed the title refactor token v2 models Refactor token v2 models Feb 4, 2025
Copy link
Collaborator Author

rtso commented Feb 4, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rtso rtso requested a review from yuunlimm February 4, 2025 21:57
@rtso rtso marked this pull request as ready for review February 4, 2025 21:57
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 40.46823% with 356 lines in your changes missing coverage. Please review.

Project coverage is 50.5%. Comparing base (279ad33) to head (f408995).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...mmon/models/token_v2_models/v2_token_ownerships.rs 30.0% 72 Missing ⚠️
...db/common/models/token_v2_models/v2_token_datas.rs 30.4% 64 Missing ⚠️
.../src/db/common/models/token_models/token_claims.rs 32.7% 39 Missing ⚠️
...ust/processor/src/processors/token_v2_processor.rs 59.7% 35 Missing ⚠️
...src/db/common/models/token_models/token_royalty.rs 64.7% 30 Missing ⚠️
...t_token_v2_processor/parquet_token_v2_extractor.rs 0.0% 29 Missing ⚠️
...mmon/models/token_v2_models/v2_token_activities.rs 42.5% 27 Missing ⚠️
...common/models/token_v2_models/v2_token_metadata.rs 4.5% 21 Missing ⚠️
...s/parquet_processors/parquet_token_v2_processor.rs 0.0% 18 Missing ⚠️
...processor/src/processors/nft_metadata_processor.rs 0.0% 13 Missing ⚠️
... and 1 more
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #704     +/-   ##
=======================================
+ Coverage   50.0%   50.5%   +0.5%     
=======================================
  Files        251     239     -12     
  Lines      28335   27984    -351     
=======================================
- Hits       14181   14156     -25     
+ Misses     14154   13828    -326     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yuunlimm yuunlimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

}
}

impl GetTimeStamp for ParquetCurrentTokenRoyaltyV1 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: when you migrate, this can be removed

self.token_data_id.cmp(&other.token_data_id)
}
}
impl PartialOrd for PostgresCurrentTokenRoyaltyV1 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra space

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants