Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix asset_type_v1 null issue #702

Merged
merged 1 commit into from
Feb 3, 2025
Merged

fix asset_type_v1 null issue #702

merged 1 commit into from
Feb 3, 2025

Conversation

bowenyang007
Copy link
Collaborator

Summary

Not sure why diesel is being weird here and overriding field with null even though treat_none_as_null is false.

Backfill

When first v2 only apt was created.
Testnet: 2598047902
Mainnet: 1669115601

Test

asset_type_v1 was null before
image

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.0%. Comparing base (89e0159) to head (78f6a3f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #702   +/-   ##
=====================================
  Coverage   50.0%   50.0%           
=====================================
  Files        251     251           
  Lines      28334   28335    +1     
=====================================
+ Hits       14169   14170    +1     
  Misses     14165   14165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bowenyang007 bowenyang007 requested review from rtso and yuunlimm February 1, 2025 22:06
@bowenyang007
Copy link
Collaborator Author

Not sure what's happening here. Locally these tests pass. Are the flaky or did something actually change @yuunlimm ?

@bowenyang007 bowenyang007 enabled auto-merge (squash) February 1, 2025 22:24
@bowenyang007 bowenyang007 merged commit 279ad33 into main Feb 3, 2025
11 checks passed
@bowenyang007 bowenyang007 deleted the fix_null_override branch February 3, 2025 15:26
@rtso
Copy link
Collaborator

rtso commented Feb 3, 2025

@bowenyang007 @yuunlimm they're passing bc there aren't any tests that process multiple txn's, but we should add them as fast follow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants