Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the processor status. #233

Merged
merged 3 commits into from
Jan 16, 2024
Merged

update the processor status. #233

merged 3 commits into from
Jan 16, 2024

Conversation

larry-aptos
Copy link
Contributor

  • This change updates the processor status to include latest transaction timestamp in the table.

rtso
rtso reviewed Jan 12, 2024
View reviewed changes
bowenyang007
bowenyang007 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@bowenyang007 bowenyang007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments to address. Otherwise looks good!

@larry-aptos larry-aptos force-pushed the update-the-processor-status branch from 0a4adc5 to f8c37ba Compare January 12, 2024 01:26
bowenyang007
bowenyang007 reviewed Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@bowenyang007 bowenyang007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please reuse utils function

@rtso
Copy link
Collaborator

rtso commented Jan 12, 2024

Use this commit to fix the lint ffcc60b

@bowenyang007
Copy link
Collaborator

That PR isn't ready though. Just fix lint here.

bowenyang007
bowenyang007 requested changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@bowenyang007 bowenyang007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

bowenyang007
bowenyang007 reviewed Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@bowenyang007 bowenyang007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there. fix lint and don't copy the same code lol
image

rtso
rtso reviewed Jan 16, 2024
View reviewed changes
@larry-aptos larry-aptos force-pushed the update-the-processor-status branch 2 times, most recently from 70af2a2 to 046d2c2 Compare January 16, 2024 20:58
@larry-aptos larry-aptos force-pushed the update-the-processor-status branch from 046d2c2 to 6a2264c Compare January 16, 2024 20:59
@larry-aptos larry-aptos merged commit 220b87f into main Jan 16, 2024
7 checks passed
@larry-aptos larry-aptos deleted the update-the-processor-status branch January 16, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowenyang007 bowenyang007 bowenyang007 approved these changes

@rtso rtso rtso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larry-aptos @rtso @bowenyang007