[Consensus Observer] Fix new pipeline. #15803

JoshLind · 2025-01-23T22:17:40Z

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

trunk-io · 2025-01-23T22:17:44Z

⏱️ 3h 13m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	1h 12m	🟩 🟩 🟩 🟩 🟩
execution-performance / test-target-determinator	27m	🟩 🟩 🟩 🟩 🟩
test-target-determinator	24m	🟩 🟩 🟩 🟩 🟩
check-dynamic-deps	18m	🟩 🟩 🟩 🟩 🟩 (+1 more)
rust-cargo-deny	8m	🟩 🟩 🟩 🟩 🟩
fetch-last-released-docker-image-tag	8m	🟩 🟩 🟩 🟩 🟩
rust-doc-tests	7m	🟩
rust-doc-tests	5m	🟩
rust-doc-tests	5m	🟩
rust-doc-tests	5m	🟩
rust-doc-tests	5m	🟩
semgrep/ci	3m	🟩 🟩 🟩 🟩 🟩 (+1 more)
general-lints	2m	🟩 🟩 🟩 🟩 🟩
file_change_determinator	57s	🟩 🟩 🟩 🟩 🟩
file_change_determinator	47s	🟩 🟩 🟩 🟩 🟩 (+1 more)

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / single-node-performance	25m	16m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

graphite-app · 2025-01-23T22:18:29Z

consensus/src/pipeline/pipeline_builder.rs

@@ -151,7 +151,7 @@ impl Tracker {
            .with_label_values(&[self.name, "work_time"])
            .observe(work_time.as_secs_f64());
        info!(
-            "[Pipeline] Block {} {} {} finishes {}, waits {}, takes {}",
+            "[Pipeline] Block {} {} {} finishes {}, waits {}ms, takes {}ms",


The log message appends ms to the time values but as_secs_f64() returns seconds. To avoid misleading logs, either convert the values to milliseconds (multiply by 1000) before logging, or remove the ms suffix to reflect the actual units in seconds.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

github-actions · 2025-01-26T15:29:34Z

✅ Forge suite `realistic_env_max_load` success on `455a26a3110d3a038da8d26082cd4b091328910a`

two traffics test: inner traffic : committed: 14735.66 txn/s, submitted: 14735.71 txn/s, expired: 0.05 txn/s, latency: 2698.03 ms, (p50: 2400 ms, p70: 2400, p90: 2700 ms, p99: 9000 ms), latency samples: 5602840
two traffics test : committed: 100.00 txn/s, latency: 1867.58 ms, (p50: 1400 ms, p70: 1400, p90: 3000 ms, p99: 10000 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.324, avg: 1.041", "ConsensusProposalToOrdered: max: 0.292, avg: 0.290", "ConsensusOrderedToCommit: max: 0.427, avg: 0.410", "ConsensusProposalToCommit: max: 0.717, avg: 0.700"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.21s no progress at version 25853 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.78s no progress at version 2311458 (avg 0.78s) [limit 16].
Test Ok

github-actions · 2025-01-26T15:30:16Z

✅ Forge suite `compat` success on `cb5d7c9615b937357dbede9439401be640fb7d17` ==> `455a26a3110d3a038da8d26082cd4b091328910a`

Compatibility test results for cb5d7c9615b937357dbede9439401be640fb7d17 ==> 455a26a3110d3a038da8d26082cd4b091328910a (PR)
1. Check liveness of validators at old version: cb5d7c9615b937357dbede9439401be640fb7d17
compatibility::simple-validator-upgrade::liveness-check : committed: 5173.35 txn/s, submitted: 5173.52 txn/s, expired: 0.17 txn/s, latency: 3026.17 ms, (p50: 2600 ms, p70: 2900, p90: 4800 ms, p99: 11000 ms), latency samples: 341949
2. Upgrading first Validator to new version: 455a26a3110d3a038da8d26082cd4b091328910a
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 4094.01 txn/s, latency: 7637.80 ms, (p50: 8400 ms, p70: 9000, p90: 9400 ms, p99: 9600 ms), latency samples: 90100
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4096.03 txn/s, latency: 8324.68 ms, (p50: 9400 ms, p70: 9400, p90: 9700 ms, p99: 9700 ms), latency samples: 143760
3. Upgrading rest of first batch to new version: 455a26a3110d3a038da8d26082cd4b091328910a
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4232.30 txn/s, latency: 7348.77 ms, (p50: 8100 ms, p70: 8800, p90: 9200 ms, p99: 9300 ms), latency samples: 91340
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4228.95 txn/s, latency: 8046.52 ms, (p50: 9000 ms, p70: 9100, p90: 9400 ms, p99: 9500 ms), latency samples: 148320
4. upgrading second batch to new version: 455a26a3110d3a038da8d26082cd4b091328910a
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 1798.76 txn/s, submitted: 1798.91 txn/s, expired: 0.15 txn/s, latency: 4418.07 ms, (p50: 4500 ms, p70: 4800, p90: 6700 ms, p99: 6800 ms), latency samples: 130249
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7291.87 txn/s, latency: 4705.28 ms, (p50: 4700 ms, p70: 5500, p90: 6000 ms, p99: 6100 ms), latency samples: 246640
5. check swarm health
Compatibility test for cb5d7c9615b937357dbede9439401be640fb7d17 ==> 455a26a3110d3a038da8d26082cd4b091328910a passed
Test Ok

JoshLind requested review from zekun000, sasha8 and ibalajiarun as code owners January 23, 2025 22:17

JoshLind added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Jan 23, 2025

graphite-app bot reviewed Jan 23, 2025

View reviewed changes