[framework] Add any_map::AnyMap #15574
Draft
+6,227
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 54m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
22 tasks
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 12, 2024
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| @@ -53,5 +53,8 @@ module aptos_std::any { | |||
| fun test_any() { | |||
| assert!(unpack<u64>(pack(22)) == 22, 1); | |||
| assert!(unpack<S>(pack(S { x: 22 })) == S { x: 22 }, 2); | |||
|
|
|||
| assert!(unpack<S>(pack(S { x: 22 })) == S { x: 22 }, 2); | |||
There was a problem hiding this comment.
Remove this line as it uses incorrect method call syntax for unpack. The assertion on line 56 already tests the same functionality with correct function call syntax.
Spotted by Graphite Reviewer (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
igor-aptos
force-pushed
the
igor/copyable_any_map
branch
from
1457de6 to
6845566
Compare
igor-aptos
changed the base branch from
igor/remove_if_present
to
igor/btree_map
This was referenced Dec 12, 2024
igor-aptos
changed the title
igor-aptos
force-pushed
the
igor/copyable_any_map
branch
from
6845566 to
3013155
Compare
igor-aptos
force-pushed
the
igor/btree_map
branch
from
4024942 to
6f26c8b
Compare
igor-aptos
force-pushed
the
igor/copyable_any_map
branch
from
3013155 to
58ebe00
Compare
igor-aptos
force-pushed
the
igor/btree_map
branch
from
6f26c8b to
0eae837
Compare
igor-aptos
force-pushed
the
igor/copyable_any_map
branch
from
58ebe00 to
6d5e10b
Compare
igor-aptos
force-pushed
the
igor/btree_map
branch
from
0eae837 to
ca43d53
Compare
igor-aptos
force-pushed
the
igor/copyable_any_map
branch
from
6d5e10b to
be8233a
Compare
22 tasks
igor-aptos
force-pushed
the
igor/btree_map
branch
from
ca43d53 to
6cd4fcf
Compare
igor-aptos
force-pushed
the
igor/btree_map
branch
from
9b16865 to
f5cf9c7
Compare
igor-aptos
force-pushed
the
igor/btree_map
branch
from
f5cf9c7 to
cbb63e1
Compare
igor-aptos
force-pushed
the
igor/copyable_any_map
branch
from
7295cea to
c54c812
Compare
igor-aptos
force-pushed
the
igor/btree_map
branch
7 times, most recently
from
e928925 to
294b435
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist