-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compiler-v2] Set V2 as the default compiler #15408
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 2h 2m total CI duration on this PR
|
rahxephon89
force-pushed
the
teng/use-v2-as-default-in-rust-unit-tests
branch
2 times, most recently
from
December 2, 2024 19:09
db094c9
to
2c9bf22
Compare
rahxephon89
force-pushed
the
teng/use-v2-as-default-in-rust-unit-tests
branch
2 times, most recently
from
December 16, 2024 00:02
9eaa4ab
to
4826561
Compare
rahxephon89
changed the title
[test-only] set v2 flag for unit tests
[test-only] Set V2 as the default compiler
Dec 16, 2024
rahxephon89
force-pushed
the
teng/use-v2-as-default-in-rust-unit-tests
branch
2 times, most recently
from
December 16, 2024 17:30
94b157a
to
d6cfb28
Compare
rahxephon89
force-pushed
the
teng/use-v2-as-default-in-rust-unit-tests
branch
10 times, most recently
from
January 7, 2025 05:06
e51881b
to
353e020
Compare
rahxephon89
changed the title
[test-only] Set V2 as the default compiler
[compiler-v2] Set V2 as the default compiler
Jan 7, 2025
rahxephon89
force-pushed
the
teng/use-v2-as-default-in-rust-unit-tests
branch
3 times, most recently
from
January 7, 2025 06:20
f7d532a
to
9cfa04d
Compare
rahxephon89
requested review from
davidiw,
movekevin,
wrwg,
banool,
gregnazario and
0xmaayan
as code owners
January 7, 2025 18:18
rahxephon89
force-pushed
the
teng/use-v2-as-default-in-rust-unit-tests
branch
from
January 9, 2025 21:54
e9531c8
to
2ad1a64
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rahxephon89
force-pushed
the
teng/use-v2-as-default-in-rust-unit-tests
branch
from
January 10, 2025 19:44
2b190e8
to
8b3915d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
aptos-move
;MOVE_COMPILER_V1
environment variable.close #13869
Note:
will have a separate PR to remove all v2_exp files once exp files in this PR are manually verified.
Following crates in
third_party/move
are still using V1 compiler API. Will switch to V2 in a separate PR.How Has This Been Tested?
All existing tests pass.
Key Areas to Review
Changes are scattered in the while aptos-core repo, need to carefully check whether these changes are correct and complete
Type of Change
Which Components or Systems Does This Change Impact?
Checklist