Enable Simulation Without Auth Key and Gas Fee Checks

This PR enhances the simulation functionality by allowing it to run without checking:
* authentication keys
* a gas fee payer and their sufficient funds for gas payment

This removed the mandatory check for an authentication key during simulations.

This also removed the requirement for a gas fee payer during simulations.
Simulations will no longer validate the presence of sufficient funds for gas payment, allowing developers to test scenarios without considering gas fees.

These changes are aimed at improving the flexibility of the simulation environment by allowing developers to test transactions and interactions without the constraints of authentication keys and gas fee payments.

api/types/src/transaction.rs

@@ -1633,6 +1633,7 @@ pub enum AccountSignature {
     MultiEd25519Signature(MultiEd25519Signature),
     SingleKeySignature(SingleKeySignature),
     MultiKeySignature(MultiKeySignature),
+    NoAccountSignature,
 }
 
 impl VerifyInput for AccountSignature {
@@ -1642,6 +1643,7 @@ impl VerifyInput for AccountSignature {
             AccountSignature::MultiEd25519Signature(inner) => inner.verify(),
             AccountSignature::SingleKeySignature(inner) => inner.verify(),
             AccountSignature::MultiKeySignature(inner) => inner.verify(),
+            AccountSignature::NoAccountSignature => Ok(()),
         }
     }
 }
@@ -1815,6 +1817,7 @@ impl From<&AccountAuthenticator> for AccountSignature {
                     signatures_required: public_keys.signatures_required(),
                 })
             },
+            NoAccountAuthenticator => unreachable!(), // TODO: error or something else?
         }
     }
 }

aptos-move/aptos-release-builder/src/components/feature_flags.rs

@@ -121,6 +121,7 @@ pub enum FeatureFlag {
     DefaultToConcurrentFungibleBalance,
     LimitVMTypeSize,
     AbortIfMultisigPayloadMismatch,
+    SimulationEnhancement,
 }
 
 fn generate_features_blob(writer: &CodeWriter, data: &[u64]) {
@@ -316,6 +317,7 @@ impl From<FeatureFlag> for AptosFeatureFlag {
             FeatureFlag::AbortIfMultisigPayloadMismatch => {
                 AptosFeatureFlag::ABORT_IF_MULTISIG_PAYLOAD_MISMATCH
             },
+            FeatureFlag::SimulationEnhancement => AptosFeatureFlag::SIMULATION_ENHANCEMENT,
         }
     }
 }
@@ -440,6 +442,7 @@ impl From<AptosFeatureFlag> for FeatureFlag {
             AptosFeatureFlag::ABORT_IF_MULTISIG_PAYLOAD_MISMATCH => {
                 FeatureFlag::AbortIfMultisigPayloadMismatch
             },
+            AptosFeatureFlag::SIMULATION_ENHANCEMENT => FeatureFlag::SimulationEnhancement,
         }
     }
 }

aptos-move/aptos-vm/src/aptos_vm.rs

@@ -683,6 +683,7 @@ impl AptosVM {
                     txn_data,
                     log_context,
                     traversal_context,
+                    self.is_simulation,
                 )
             })?;
             epilogue_session
@@ -710,6 +711,7 @@ impl AptosVM {
                     txn_data,
                     log_context,
                     traversal_context,
+                    self.is_simulation,
                 )
             })?;
             epilogue_session
@@ -756,6 +758,7 @@ impl AptosVM {
                 txn_data,
                 log_context,
                 traversal_context,
+                self.is_simulation,
             )
         })?;
         let change_set = epilogue_session.finish(change_set_configs)?;
@@ -2342,6 +2345,7 @@ impl AptosVM {
                     txn_data,
                     log_context,
                     traversal_context,
+                    self.is_simulation,
                 )
             },
             TransactionPayload::Multisig(multisig_payload) => {
@@ -2353,6 +2357,7 @@ impl AptosVM {
                     txn_data,
                     log_context,
                     traversal_context,
+                    self.is_simulation,
                 )?;
                 // Skip validation if this is part of tx simulation.
                 // This allows simulating multisig txs without having to first create the multisig

aptos-move/aptos-vm/src/transaction_metadata.rs

@@ -38,20 +38,29 @@ impl TransactionMetadata {
     pub fn new(txn: &SignedTransaction) -> Self {
         Self {
             sender: txn.sender(),
-            authentication_key: txn.authenticator().sender().authentication_key().to_vec(),
+            authentication_key: txn
+                .authenticator()
+                .sender()
+                .authentication_key()
+                .map_or_else(|| vec![], |auth_key| auth_key.to_vec()),
             secondary_signers: txn.authenticator().secondary_signer_addresses(),
             secondary_authentication_keys: txn
                 .authenticator()
                 .secondary_signers()
                 .iter()
-                .map(|account_auth| account_auth.authentication_key().to_vec())
+                .map(|account_auth| {
+                    account_auth
+                        .authentication_key()
+                        .map_or_else(|| vec![], |auth_key| auth_key.to_vec())
+                })
                 .collect(),
             sequence_number: txn.sequence_number(),
             fee_payer: txn.authenticator_ref().fee_payer_address(),
-            fee_payer_authentication_key: txn
-                .authenticator()
-                .fee_payer_signer()
-                .map(|signer| signer.authentication_key().to_vec()),
+            fee_payer_authentication_key: txn.authenticator().fee_payer_signer().map(|signer| {
+                signer
+                    .authentication_key()
+                    .map_or_else(|| vec![], |auth_key| auth_key.to_vec())
+            }),
             max_gas_amount: txn.max_gas_amount().into(),
             gas_unit_price: txn.gas_unit_price().into(),
             transaction_size: (txn.raw_txn_bytes_len() as u64).into(),

aptos-move/aptos-vm/src/transaction_validation.rs

@@ -89,6 +89,7 @@ pub(crate) fn run_script_prologue(
     txn_data: &TransactionMetadata,
     log_context: &AdapterLogSchema,
     traversal_context: &mut TraversalContext,
+    is_simulation: bool,
 ) -> Result<(), VMStatus> {
     let txn_sequence_number = txn_data.sequence_number();
     let txn_authentication_key = txn_data.authentication_key().to_vec();
@@ -118,6 +119,7 @@ pub(crate) fn run_script_prologue(
             MoveValue::U64(txn_max_gas_units.into()),
             MoveValue::U64(txn_expiration_timestamp_secs),
             MoveValue::U8(chain_id.id()),
+            MoveValue::Bool(is_simulation),
         ];
         if txn_data.required_deposit.is_some() {
             args.push(txn_data.required_deposit.as_move_value());
@@ -139,6 +141,7 @@ pub(crate) fn run_script_prologue(
             MoveValue::U64(txn_max_gas_units.into()),
             MoveValue::U64(txn_expiration_timestamp_secs),
             MoveValue::U8(chain_id.id()),
+            MoveValue::Bool(is_simulation),
         ];
         (
             &APTOS_TRANSACTION_VALIDATION.multi_agent_prologue_name,
@@ -154,6 +157,7 @@ pub(crate) fn run_script_prologue(
             MoveValue::U64(txn_expiration_timestamp_secs),
             MoveValue::U8(chain_id.id()),
             MoveValue::vector_u8(txn_data.script_hash.clone()),
+            MoveValue::Bool(is_simulation),
         ];
         if txn_data.required_deposit.is_some() {
             args.push(txn_data.required_deposit.as_move_value());
@@ -229,6 +233,7 @@ fn run_epilogue(
     txn_data: &TransactionMetadata,
     features: &Features,
     traversal_context: &mut TraversalContext,
+    is_simulation: bool,
 ) -> VMResult<()> {
     let txn_gas_price = txn_data.gas_unit_price();
     let txn_max_gas_units = txn_data.max_gas_amount();
@@ -244,6 +249,7 @@ fn run_epilogue(
                 MoveValue::U64(txn_gas_price.into()),
                 MoveValue::U64(txn_max_gas_units.into()),
                 MoveValue::U64(gas_remaining.into()),
+                MoveValue::Bool(is_simulation),
             ];
             if txn_data.required_deposit.is_some() {
                 args.push(txn_data.required_deposit.as_move_value());
@@ -275,6 +281,7 @@ fn run_epilogue(
                 MoveValue::U64(txn_gas_price.into()),
                 MoveValue::U64(txn_max_gas_units.into()),
                 MoveValue::U64(gas_remaining.into()),
+                MoveValue::Bool(is_simulation),
             ];
             if txn_data.required_deposit.is_some() {
                 args.push(txn_data.required_deposit.as_move_value());
@@ -335,6 +342,7 @@ pub(crate) fn run_success_epilogue(
     txn_data: &TransactionMetadata,
     log_context: &AdapterLogSchema,
     traversal_context: &mut TraversalContext,
+    is_simulation: bool,
 ) -> Result<(), VMStatus> {
     fail_point!("move_adapter::run_success_epilogue", |_| {
         Err(VMStatus::error(
@@ -350,6 +358,7 @@ pub(crate) fn run_success_epilogue(
         txn_data,
         features,
         traversal_context,
+        is_simulation,
     )
     .or_else(|err| convert_epilogue_error(err, log_context))
 }
@@ -364,6 +373,7 @@ pub(crate) fn run_failure_epilogue(
     txn_data: &TransactionMetadata,
     log_context: &AdapterLogSchema,
     traversal_context: &mut TraversalContext,
+    is_simulation: bool,
 ) -> Result<(), VMStatus> {
     run_epilogue(
         session,
@@ -372,6 +382,7 @@ pub(crate) fn run_failure_epilogue(
         txn_data,
         features,
         traversal_context,
+        is_simulation,
     )
     .or_else(|e| {
         expect_only_successful_execution(