Skip unchanged vars when updating config #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using a direct docker image deployment method, but this seems to always cause a redeployment, which is not desirable.
The root cause is that if
APTIBLE_DOCKER_IMAGE
appears in the config map (see: https://github.com/aptible/go-deploy/blob/master/aptible/app.go#L121), it triggers a deployment rather than a config update.I've created this code as a complete Go n00b, but wanted to demo what would be a useful solution to me: not setting the unchanged variables. In my case this means that the unchanged
APTIBLE_DOCKER_IMAGE
key will get dropped and a configuration change will be applied rather than a deployment inDeployApp
(as far as I can tell)If this solution is not acceptable, one alternative which would also be useful is to have a sentinel value for
APTIBLE_DOCKER_IMAGE
, which when used will avoid the redeployment