Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate service_sizing_policy in favor of autoscaling_policy #125

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

mdelaossa
Copy link
Member

@mdelaossa mdelaossa commented Dec 10, 2024

@mdelaossa mdelaossa requested review from joshraker and aaw and removed request for joshraker December 10, 2024 21:33
@aaw
Copy link
Contributor

aaw commented Dec 12, 2024

Why not keep service_scaling_policy but mark it deprecated (as described here)?

So you'd basically have both service_scaling_policy and autoscaling_policy defined, they'd both do exactly the same thing but anyone using service_scaling_policy would get a deprecation message. The deprecation message could warn them to use autoscaling_policy and that service_scaling_policy is going to disappear in 1.x.

@mdelaossa
Copy link
Member Author

Why not keep service_scaling_policy but mark it deprecated (as described here)?

So you'd basically have both service_scaling_policy and autoscaling_policy defined, they'd both do exactly the same thing but anyone using service_scaling_policy would get a deprecation message. The deprecation message could warn them to use autoscaling_policy and that service_scaling_policy is going to disappear in 1.x.

I was thinking since it's a beta feature it was perfectly fine, but... you're right, this client is public which means people other than the beta users have access to it. Will do proper deprecation

@mdelaossa mdelaossa changed the title Rename service_sizing_policy to autoscaling_policy Deprecate service_sizing_policy in favor of autoscaling_policy Dec 12, 2024
@mdelaossa
Copy link
Member Author

ready for review 👍

@mdelaossa mdelaossa merged commit fd53e39 into master Dec 12, 2024
3 checks passed
@mdelaossa mdelaossa deleted the sc-29017 branch December 12, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants