Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile added #98

Closed
wants to merge 4 commits into from
Closed

Dockerfile added #98

wants to merge 4 commits into from

Conversation

tarampampam
Copy link

@tarampampam tarampampam commented Jan 17, 2022

Related issue: #85

Suggested workflow for the images publishing on docker hub & GitHub containers (using GitHub actions):

name: release

on:
  release: # Docs: <https://git.io/JeBz1#release-event-release>
    types: [published]

jobs:
  docker-image:
    name: Build docker image
    runs-on: ubuntu-20.04
    steps:
      - uses: actions/checkout@v2

      - uses: gacts/github-slug@v1 # Action page: <https://github.com/gacts/github-slug>
        id: slug

      - uses: docker/setup-qemu-action@v1 # Action page: <https://github.com/docker/setup-qemu-action>

      - uses: docker/setup-buildx-action@v1 # Action page: <https://github.com/docker/setup-buildx-action>

      - uses: docker/login-action@v1 # Action page: <https://github.com/docker/login-action>
        with:
          username: aptible
          password: ${{ secrets.DOCKER_PASSWORD }}

      - uses: docker/login-action@v1 # Action page: <https://github.com/docker/login-action>
        with:
          registry: ghcr.io
          username: ${{ github.actor }}
          password: ${{ secrets.GITHUB_TOKEN }}

      - uses: docker/build-push-action@v2 # Action page: <https://github.com/docker/build-push-action>
        with:
          context: .
          file: Dockerfile
          push: true
          platforms: linux/amd64,linux/arm64,linux/arm/v6,linux/arm/v7
          tags: |
            aptible/supercronic:${{ steps.slug.outputs.version }}
            aptible/supercronic:latest
            ghcr.io/aptible/supercronic:${{ steps.slug.outputs.version }}
            ghcr.io/aptible/supercronic:latest

@tarampampam tarampampam marked this pull request as ready for review January 17, 2022 06:28
@tarampampam
Copy link
Author

Friendly ping @krallin

@krallin
Copy link
Collaborator

krallin commented Jan 29, 2022

While I've got push access to the repo, the release workflow is something that should probably be looked at by the Aptible folks since I don't have admin access to set up actions here.

@fancyremarker, thoughts? Note that the case for this existing is explained in #85, it's to use it as a COPY --from source (which IMO makes sense), not as a base image (which IMO does not and I think there are historical issues here explaining the reasoning)

@krallin krallin requested review from fancyremarker and removed request for krallin January 29, 2022 12:42
@tarampampam
Copy link
Author

Friendly ping @fancyremarker

@tarampampam
Copy link
Author

Any news?

@fancyremarker
Copy link
Member

Hi @tarampampam , sorry for the delay! To clarify, are you suggesting that the workflow in your PR message be used as .github/workflows/release.yml? I'm not clear why we'd (also) want the image.tar upload that's in tests.yml in the PR.

Assuming you're looking for us to build and host an image, we can set that up. We'd want it to be hosted on Docker Hub and Quay, our 2 registries. (We don't currently use GitHub Packages.) Our team can make that change, but first I want to make sure I'm understanding the intent here.

@tarampampam
Copy link
Author

are you suggesting that the workflow in your PR message be used as .github/workflows/release.yml?

Yes

I'm not clear why we'd (also) want the image.tar upload that's in tests.yml in the PR

For the image testing in the next jobs, for example. Removed

@tarampampam
Copy link
Author

Ping?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants