WIP: Upstream updates #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix URL path
…e#30) Also, use thin to serve the example over https. u2f-api.js comes from https://github.com/google/u2f-ref-code/tree/master/u2f-gae-demo/war/js/u2f-api.js
* Serious cleanup including freezing constants and replacing fail with raise * Restore equals alignment
* Get example working with version 1.0 of the gem.
This involves updates to work with the new-model stripped-down
'request' Ruby objects, which don't have an embedded appId or
challenges of their own. (And also updates to the example's
own Gemfile, of course.)
* Update README for version 1.1 U2F/JS API, version 1.0 gem API.
This requires supplying appId and challenge values to JS separately
from the request objects (which no longer have these items bundled),
and deleting 'as_json' method invocations which appear to no longer
be necessary.
* Make README use <%= ... %> ERB syntax consistently.
Corrects some usages of #{...} syntax taken from HAML in the
example code.
* Validate the JSON data in load Check to make sure that the loaded JSON actually contains data in the keys we are going to use before we use them, to avoid runtime exceptions on Nil. * Raise error on bad response data When trying to sign response make sue the data is correct and raise a known error rather than a method missing error on bad data. * Bad request constant * Add test for invalid JSON error * Add test for handling invalid response data * Fix typo * Use nil instead of blank * Use key instead of blank * Change .nil? checks to .key? * Change error from bad data code to invalid json message * oops * Fix test * Fix error * Fix sign response
* Move test dependencies out of gemspec * Added rubocop config * Added latest Ruby to travis * Fix Style/StringLiterals * Fix Layout/SpaceAfterSemicolon * Fix Style/FrozenStringLiteralComment * Cleanup specs * Drop support for Ruby 2.0 * Fix more styling * Use tap * Fix scoping
* Upgrade gems 2018-09-06 * Drop support for Ruby 2.1 * Update badge images
cleanup ruby versions
bump-gems-2018-10-03
bump-gems-2018-10-15
bump-gems-2018-11-06
Drop support for ruby 2.2
bump ruby versions and add coditsu v2
move version to proper location
bump-gems-2019-01-19
fix coditsu
update ruby versions
update coditsu integration
bump-gems-2019-06-10
bump-gems-2019-06-25
bump-gems-2019-09-05
bump-gems-2019-10-14
bump-gems-2019-11-06
bump-gems-2019-11-17
bump-gems-2020-03-02
bump-gems-2020-05-21
Update some dependencies
Update dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: this currently merges the latest from https://github.com/castle/ruby-u2f, however this needs a lot of attention before we can merge.