chore: fix last scale banner #964
Open
+162
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot always find the last (2) scale operations in order to render the from and to container profile and sizes. This change makes it so we do not show inaccurate information to the user.
neurosnap
force-pushed
the
fix-last-scale
branch
from
ea55037
to
e90b612
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot always find the last (2) scale operations in order to render the from and to container profile and sizes. This change makes it so we do not show inaccurate information to the user.
Further, scale operations do not always have all the properties we want to present to the user so we need to do some parsing to properly render the text.