add-diagnostics-exploration #1001
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature-flag the sidebar entry
eabruzzese
force-pushed
the
add-diagnostics
branch
from
bddc100 to
b88253f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo
• Turn static code into working code (Make charts & form real)
• Add delete chart fuctionality (wire up the delete button on diagnostic-detail-page.tsx)
• Add different component for charts (line-chart, bar-chart, etc..) into the diagnostic-detail-page.tsx
• Wire up rating buttons for charts
• Wire up view source button for charts
• Make Diagnostic table into a shared component
• Add Diagnostics tab on App Detail Page (maybe before Settings)
• Add Diagnostics tab on Services Detail Page (maybe before Settings)
• Populate Environment and App fields based on the app source of the New Diagnostic button (ex. its app detail page)
App Detail Page
• If we add a Diagnostics Tab, We might not need to add the button here too, but the tab should be moved earlier in priority (I think in the 2nd position) @fancyremarker
App Detail Page / Diagnostics Tab
• Photoshop mockup, not in code
Diagnostics Detail Page
• No charts show during creation & show app's name in breadcrumb (ex. app-name / New Diagnostics)
• Chart is missing
Global Diagnostics Page
Global Diagnostics Page / Create Diagnostic
• I think this will help with discoverability and teaching users how this feature works.