Skip to content

Add new Example20 with interaction queues instead of SOAData #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

hahnjo
Copy link
Contributor

@hahnjo hahnjo commented Nov 1, 2022

This revives an old concept from the toy examples 1, 2, and 4 (deleted in commit 9230c4a) to have one queue per discrete interaction. This appears to be equally fast as the quite complex scheduling kernel based on SOAData.

@bernhardmgruber see here for not using __shared__ memory in Example19 as mentioned here: #229 (comment)

@hahnjo hahnjo requested a review from hageboeck November 1, 2022 11:06
@phsft-bot
Copy link

Can one of the admins verify this patch?

@hageboeck
Copy link
Contributor

Great to see that this works, thanks. Have you considered creating an example20 out of this, and document the difference to ex19 as was done for the other examples?

@hahnjo
Copy link
Contributor Author

hahnjo commented Nov 1, 2022

Great to see that this works, thanks. Have you considered creating an example20 out of this, and document the difference to ex19 as was done for the other examples?

Yes, and I can do so if you want. However, there is no difference in the executed workflow, it's just implemented differently. In the past, we did these "technical improvements" within existing examples...

@hahnjo hahnjo force-pushed the example19-interaction-queues branch 2 times, most recently from 1a2bbfb to 61e33bc Compare November 9, 2022 09:06
@hageboeck
Copy link
Contributor

Yes, and I can do so if you want. However, there is no difference in the executed workflow, it's just implemented differently. In the past, we did these "technical improvements" within existing examples...

Yes, please do so. Thanks!

This revives an old concept from the toy examples 1, 2, and 4 (deleted
in commit 9230c4a) to have one queue per discrete interaction. This
appears to be equally fast as the quite complex scheduling kernel based
on SOAData.
@hahnjo hahnjo changed the title example19: Use interaction queues instead of SOAData Add new Example20 with interaction queues instead of SOAData Nov 23, 2022
@hahnjo hahnjo force-pushed the example19-interaction-queues branch from 61e33bc to 5d8bdf8 Compare November 23, 2022 16:12
@hahnjo
Copy link
Contributor Author

hahnjo commented Nov 23, 2022

Yes, and I can do so if you want. However, there is no difference in the executed workflow, it's just implemented differently. In the past, we did these "technical improvements" within existing examples...

Yes, please do so. Thanks!

Done. Would be interesting to know what you have in mind with example19 using the SOAData...

@agheata agheata merged commit d139cbb into apt-sim:master Jan 13, 2023
@hahnjo hahnjo deleted the example19-interaction-queues branch January 13, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants