Mark a track's survival more explicit #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a lambda function survive() which pushes the track back into the active queue.
|
Can one of the admins verify this patch? |
|
One of the CI runs is failing with: I don't have experience with the CI. Can someone please have a look and fix it? Thx! |
1 task
bernhardmgruber
force-pushed
the
survival_lambda
branch
from
3a5fc3e to
71683da
Compare
hahnjo
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a lambda function
survive()which pushes the track back into the active queue.Running
example19 -particles 10000 -batch 5000 -gdml_file ../examples/Example14/macros/testEm3.gdml5x on V100:before:
Mean: 4.00011
Stddev: 0.00030375
after:
Mean: 4.01492
Stddev: 0.000460478
Output is identical. The slight slowdown is surprising, but it is by far compensated by the subsequent optimizations based on this PR, See #225 and #229.