Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove rails 6 support #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions Appraisals
Original file line number Diff line number Diff line change
@@ -1,15 +1,8 @@
# frozen_string_literal: true

appraise 'rails_6.1' do
gem 'rails', '~> 6.1'
gem 'rspec', '~> 3.10'
gem 'rspec-rails', '~> 5.1'
gem 'sqlite3', '~> 1.5'
end

appraise 'rails_7.0' do
gem 'rails', '~> 7.0'
gem 'rspec', '~> 3.12'
gem 'rspec-rails', '~> 6.0'
gem 'rspec-rails', '~> 7.0'
gem 'sqlite3', '~> 1.5'
end
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,6 @@ Tests are written using [RSpec](https://rspec.info/) and are setup to use [Appra
$ bundle exec appraisal rspec spec/path/to/spec.rb

To run just a particular rails version:
$ bundle exec appraisal rails_6.1 rspec
$ bundle exec appraisal rails_7.0 rspec

### Console
Expand Down
10 changes: 0 additions & 10 deletions gemfiles/rails_6.1.gemfile

This file was deleted.

2 changes: 1 addition & 1 deletion gemfiles/rails_7.0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ source "https://rubygems.org"

gem "rails", "~> 7.0"
gem "rspec", "~> 3.12"
gem "rspec-rails", "~> 6.0"
gem "rspec-rails", "~> 7.0"
gem "sqlite3", "~> 1.5"

gemspec path: "../"
2 changes: 1 addition & 1 deletion phi_attrs.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Gem::Specification.new do |spec|
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ['lib']

spec.add_dependency 'rails', '>= 6.0.0'
spec.add_dependency 'rails', '>= 7.0.0'
spec.add_dependency 'request_store', '~> 1.4'

spec.add_development_dependency 'appraisal'
Expand Down
2 changes: 0 additions & 2 deletions spec/dummy/application.rb
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ class Application < Rails::Application
config.paths['log'] = 'tmp/log/development.log'
config.paths.add 'config/routes.rb', with: "#{APP_ROOT}/config/routes.rb"

config.active_record.sqlite3.represent_boolean_as_integer = true if Rails.version.match?(/^6.0/)

def require_environment!
initialize!
end
Expand Down
Loading