Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ansible-lint happy #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

britthouser
Copy link
Contributor

Ansible-lint through a couple warnings when run against
this role. I udpated the two warnings, and also raised
the minimum ansible version required for the systemd change.

@britthouser
Copy link
Contributor Author

@aprt5pr - with this change, ansible-lint could be added as another gate check as well.

@aprt5pr
Copy link
Owner

aprt5pr commented Apr 1, 2019

@britthouser the tests are failing for both CentOS and Ubuntu. Let's see if we can sort that out before merging this.

Ansible-lint through a couple warnings when run against
this role.  I udpated the two warnings, and also raised
the minimum ansible version required for the systemd change.
@britthouser
Copy link
Contributor Author

Sounds good @aprt5pr. I just rebased this on top of #5 . Hopefully that will fix CentOS gate. I'm not sure what is wrong with Debian gate.

@britthouser
Copy link
Contributor Author

Yeah it looks like CentOS gate is happy now, but the Ubuntu gate is giving this error:

TASK [lansible-role-ocserv : Start and enable Ocserv] **************************
fatal: [localhost]: FAILED! => {"changed": false, "cmd": "/bin/systemctl", "msg": "Failed to connect to bus: No such file or directory", "rc": 1, "stderr": "Failed to connect to bus: No such file or directory\n", "stderr_lines": ["Failed to connect to bus: No such file or directory"], "stdout": "", "stdout_lines": []}

I wonder if this is an issue due to running in a container rather than VM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants