[CLI] Use || instead of ?? because getEndpoint() can return ""
#984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
force-pushed
the
fix-139-invalid-url
branch
2 times, most recently
from
51ee938 to
15e8f73
Compare
stnguyen90
changed the title
|| instead of ?? because getEndpoint() can return ""
stnguyen90
force-pushed
the
fix-139-invalid-url
branch
from
15e8f73 to
78d8bcb
Compare
Since the `??` operator only returns the right side if the left side is null or undefined, it will not work if `getEndpoint()` returns an empty string. `||`, however, will return the right side if the left side is an empty string.
stnguyen90
force-pushed
the
fix-139-invalid-url
branch
from
78d8bcb to
ff27108
Compare
christyjacob4
approved these changes
Sep 19, 2024
byawitz
approved these changes
Sep 19, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Since the
??operator only returns the right side if the left side is null or undefined, it will not work ifgetEndpoint()returns an empty string.||, however, will return the right side if the left side is an empty string.Fixes appwrite/sdk-for-cli#139
Test Plan
Before:
After:
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes