Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix- Flutter & Dart SDK score #710

Merged
merged 20 commits into from
Mar 24, 2024
Merged

Fix- Flutter & Dart SDK score #710

merged 20 commits into from
Mar 24, 2024

Conversation

lohanidamodar
Copy link
Member

@lohanidamodar lohanidamodar commented Sep 4, 2023 •
edited by stnguyen90
Loading

What does this PR do?

  • Update flutter dependencies
  • Update dart dependencies
  • Update fixes for dart/flutter latest static analysis changes
  • Update flutter docker image used for testing, as the image we were previously using has not been updated for 10months now.

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@github-actions github-actions bot mentioned this pull request Oct 1, 2023
Closed
stnguyen90
stnguyen90 reviewed Jan 3, 2024
View reviewed changes
tests/FlutterBetaTest.php Show resolved Hide resolved
templates/node/package.json.twig Outdated Show resolved Hide resolved
@lohanidamodar lohanidamodar changed the title update dependencies Fix- Flutter & Dart SDK score Mar 10, 2024
stnguyen90
stnguyen90 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated the SDK and tested it with the playground and it ran successfully.

@lohanidamodar lohanidamodar merged commit ad80d80 into master Mar 24, 2024
34 checks passed
@lohanidamodar lohanidamodar deleted the feat-dependency-upgrades-2 branch March 24, 2024 05:41
@stnguyen90 stnguyen90 mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 stnguyen90 approved these changes

@abnegate abnegate Awaiting requested review from abnegate

@christyjacob4 christyjacob4 Awaiting requested review from christyjacob4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lohanidamodar @stnguyen90 @christyjacob4