Skip to content

Commit

Permalink
test: enable node 20 disable 14
Browse files Browse the repository at this point in the history
  • Loading branch information
loks0n committed Dec 14, 2023
1 parent 0b367db commit ffcd357
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
fail-fast: false
matrix:
php-version: ['8.1']
sdk: [Android11Java8, Android11Java11, Android12Java8, Android12Java11, CLINode14, CLINode16, DartBeta, DartStable, Deno1193, Deno1303, DotNet60, DotNet70, FlutterStable, FlutterBeta, Go112, Go118, KotlinJava8, KotlinJava11, KotlinJava17, Node14, Node16, Node18, PHP74, PHP80, Python38, Python39, Python310, Ruby27, Ruby30, Ruby31, AppleSwift55, Swift55, WebChromium, WebNode]
sdk: [Android11Java8, Android11Java11, Android12Java8, Android12Java11, CLINode14, CLINode16, DartBeta, DartStable, Deno1193, Deno1303, DotNet60, DotNet70, FlutterStable, FlutterBeta, Go112, Go118, KotlinJava8, KotlinJava11, KotlinJava17, Node16, Node18, Node20, PHP74, PHP80, Python38, Python39, Python310, Ruby27, Ruby30, Ruby31, AppleSwift55, Swift55, WebChromium, WebNode]

steps:
- name: Checkout repository
Expand Down
6 changes: 3 additions & 3 deletions tests/Node14Test.php → tests/Node20Test.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Tests;

class Node14Test extends Base
class Node18Test extends Base
{
protected string $sdkName = 'node.js';
protected string $sdkPlatform = 'server';
Expand All @@ -12,10 +12,10 @@ class Node14Test extends Base
protected string $language = 'node';
protected string $class = 'Appwrite\SDK\Language\Node';
protected array $build = [
'docker run --rm -v $(pwd):/app -w /app/tests/sdks/node node:14-alpine npm install',
'docker run --rm -v $(pwd):/app -w /app/tests/sdks/node node:20-alpine npm install',
];
protected string $command =
'docker run --network="mockapi" --rm -v $(pwd):/app -w /app node:14-alpine node tests/languages/node/test.js';
'docker run --network="mockapi" --rm -v $(pwd):/app -w /app node:20-alpine node tests/languages/node/test.js';

protected array $expectedOutput = [
...Base::FOO_RESPONSES,
Expand Down

0 comments on commit ffcd357

Please sign in to comment.