Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting instance_type for master nodes #95

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Support setting instance_type for master nodes #95

merged 1 commit into from
Aug 30, 2024

Conversation

DebakelOrakel
Copy link
Contributor

@DebakelOrakel DebakelOrakel commented Aug 30, 2024 •
edited
Loading

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Link this PR to related issues.

@DebakelOrakel DebakelOrakel added the enhancement New feature or request label Aug 30, 2024
@DebakelOrakel DebakelOrakel requested a review from a team August 30, 2024 10:21
bastjan
bastjan approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@bastjan bastjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

standard.extra-large ought to be enough for anybody.

@DebakelOrakel DebakelOrakel merged commit e5d45c0 into master Aug 30, 2024
1 check passed
@DebakelOrakel DebakelOrakel deleted the feat/support-setting-master-type branch August 30, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastjan bastjan bastjan approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DebakelOrakel @bastjan