Add optional support for using existing floating IPs #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haasad
force-pushed
the
use-existing-floating-ips
branch
from
e137446
to
502cd76
Compare
simu
changed the title
simu
changed the title
simu
reviewed
May 3, 2024
There was a problem hiding this comment.
Please add a short note about the new option in https://github.com/appuio/terraform-modules/tree/main/modules/vshn-lbaas-cloudscale#module-input-variables
haasad
force-pushed
the
use-existing-floating-ips
branch
from
502cd76
to
cf15649
Compare
simu
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog