Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vshn-lbaas-exoscale: Update LB security group to allow SSH to the LBs from anywhere #51

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

simu
Copy link
Member

@simu simu commented Feb 15, 2024

We add explicit rules for SSH to the LBs in the LB security group as preparation for removing the SSH from anywhere rule from the all_machines security group in terraform-openshift4-exoscale.

See also appuio/terraform-openshift4-exoscale#78

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Link this PR to related issues.

@simu simu changed the base branch from main to feat/vshn-lbaas-exoscale-iamv3 February 15, 2024 12:54
@simu simu changed the title Feat/vshn lbaas exoscale/allow ssh from anywhere vshn-lbaas-exoscale: Update LB security group to allow SSH to the LBs from anywhere Feb 15, 2024
@simu simu added the enhancement New feature or request label Feb 15, 2024
simu added a commit to appuio/terraform-openshift4-exoscale that referenced this pull request Feb 15, 2024
We remove the SSH access from anywhere for the cluster VMs by updating
the `all_machines` security group to only allow SSH from other machines
in the `all_machines` security group.

This PR requires appuio/terraform-modules#51 in
order to ensure that the LBs remain accessible from anywhere via SSH and
can act as SSH jumphosts for SSH access to the cluster VMs.
@simu simu force-pushed the feat/vshn-lbaas-exoscale/allow-ssh-from-anywhere branch from efdd61d to b14ba17 Compare February 15, 2024 12:59
@simu simu changed the base branch from feat/vshn-lbaas-exoscale-iamv3 to main February 15, 2024 12:59
@simu simu marked this pull request as ready for review February 15, 2024 13:00
… from anywhere

We add explicit rules for SSH to the LBs in the LB security group as
preparation for removing the SSH from anywhere rule from the
`all_machines` security group in terraform-openshift4-exoscale.
@simu simu force-pushed the feat/vshn-lbaas-exoscale/allow-ssh-from-anywhere branch from b14ba17 to 08d4437 Compare February 15, 2024 13:05
@simu simu requested a review from a team February 15, 2024 13:06
@simu simu merged commit e14d7f4 into main Feb 15, 2024
4 checks passed
@simu simu deleted the feat/vshn-lbaas-exoscale/allow-ssh-from-anywhere branch February 15, 2024 13:18
simu added a commit to appuio/terraform-openshift4-exoscale that referenced this pull request Feb 15, 2024
We remove the SSH access from anywhere for the cluster VMs by updating
the `all_machines` security group to only allow SSH from other machines
in the `all_machines` security group.

This PR requires appuio/terraform-modules#51 in
order to ensure that the LBs remain accessible from anywhere via SSH and
can act as SSH jumphosts for SSH access to the cluster VMs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants