Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step to enable AppCat during installation on Cloudscale #257

Closed
wants to merge 1 commit into from

Conversation

glrf
Copy link
Contributor

@glrf glrf commented Jun 27, 2023

AppCat should now be enabled by default on APPUiO Managed OpenShift on Cloudscale. This simply requires adding a single class and will reuse the Cloudscale token stored under ${cluster:tenant}/${cluster:name}/cloudscale/token to provision buckets on cloudscale

@glrf glrf self-assigned this Jun 27, 2023
@glrf glrf force-pushed the feat/appcat-installation-cloudscale branch from 4d18033 to 9307976 Compare July 4, 2023 11:07
@glrf glrf marked this pull request as ready for review July 4, 2023 11:07
@glrf glrf requested a review from a team July 4, 2023 11:10
@bastjan
Copy link
Contributor

bastjan commented Jul 4, 2023

Are there no plans enabling it in global defaults?

@glrf
Copy link
Contributor Author

glrf commented Jul 4, 2023

Are there no plans enabling it in global defaults?

I'm a bit torn if we should do that, as AFAIK you can't easily "uninclude" a class and I'd generally like to have the option to easily disable appcat on a cluster

@bastjan
Copy link
Contributor

bastjan commented Jul 4, 2023

Are there no plans enabling it in global defaults?

I'm a bit torn if we should do that, as AFAIK you can't easily "uninclude" a class and I'd generally like to have the option to easily disable appcat on a cluster

I'll ask in the daily tmrw what the preferred option for Aldebaran is

@bastjan
Copy link
Contributor

bastjan commented Jul 6, 2023

We decided to have it in global defaults. We do not want more installation steps and don't see a case currently where we need to remove appcat.

@glrf
Copy link
Contributor Author

glrf commented Jul 10, 2023

Alright, in that case I'll add the class to the global defaults for OpenShift on cloudscale. If this ever gets an issue that should be easy enough to revert

@glrf glrf closed this Jul 10, 2023
@glrf glrf deleted the feat/appcat-installation-cloudscale branch July 10, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants