get the kubernetes default config, freeze pip dependencies #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtschan
reviewed
Nov 7, 2021
app.py
Outdated
| @@ -163,5 +163,5 @@ def log_message(self, format, *args): | |||
|
|
|||
|
|
|||
| if __name__ == '__main__': | |||
| httpd = ProxyHTTPServer(('127.0.0.1', 8080), partial(ProxyMetricsHandler, ProxyConfig())) | |||
| httpd = ProxyHTTPServer(('0.0.0.0', 8080), partial(ProxyMetricsHandler, ProxyConfig())) | |||
There was a problem hiding this comment.
Thx for the pull request. openshift-prometheus-proxy deliberately binds to localhost only, so that it's only reachable via OAuth Proxy. This should still work on OCP 4 as the same configuration is used by the OCP 4 monitoring stack. Have you seen issues with this code on OCP 4?
|
Yes, I deployed it using source-to-image to OCP4 and it was not reachable using 127.0.0.1. I did not test it on OCP4 using the provided config.
… Am 07.11.2021 um 16:05 schrieb Daniel Tschan ***@***.***>:
@dtschan commented on this pull request.
In app.py:
> @@ -163,5 +163,5 @@ def log_message(self, format, *args):
if __name__ == '__main__':
- httpd = ProxyHTTPServer(('127.0.0.1', 8080), partial(ProxyMetricsHandler, ProxyConfig()))
+ httpd = ProxyHTTPServer(('0.0.0.0', 8080), partial(ProxyMetricsHandler, ProxyConfig()))
Thx for the pull request. openshift-prometheus-proxy deliberately binds to localhost only, so that it's only reachable via OAuth Proxy. This should still work on OCP 4 as the same configuration is used by the OCP 4 monitoring stack. Have you seen issues with this code on OCP 4?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
I see. openshift-prometheus-proxy requires OAuth proxy to provide security and isn't designed to be used without it. Can you please remove the change on line 166. The rest of the pull request looks good. |
|
@dtschan Reverted change and added a comment 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the missing api_key of #2, which might be from an upstream Kubernetes module change?