Make hidden runbook_url annotations visible
#217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some upstream Jsonnet hides the `runbook_url` annotation on alerts. Because of that, some of our patches which insert the `runbook_url` annotation don't work correctly with go-jsonnet 0.20.0, which correctly inherits field visibility in object comprehension (e.g. `com.makeMergeable()`). This behavior will also be fixed in an upcoming C++ jsonnet version, cf. google/jsonnet#1140 so we adjust the component to make all `runbook_url` annotations visible. Notably, the upstream Jsonnet which hides the annotation also sets it to `null`, so we can then clean up the unwanted `runbook_url: null` annotations by calling `std.prune()` on the annotations object.
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
bastjan
approved these changes
Nov 1, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some upstream Jsonnet hides the
runbook_urlannotation on alerts.Because of that, some of our patches which insert the
runbook_urlannotation don't work correctly with go-jsonnet 0.20.0, which correctly inherits field visibility in object comprehension (e.g.com.makeMergeable()). This behavior will also be fixed in an upcoming C++ jsonnet version, cf. google/jsonnet#1140 so we adjust the component to make allrunbook_urlannotations visible.Notably, the upstream Jsonnet which hides the annotation also sets it to
null, so we can then clean up the unwantedrunbook_url: nullannotations by callingstd.prune()on the annotations object.Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.