Allow moving neighbouring thumbs to accommodate new thumb values (for issue #55) #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the feature. Please consider accepting the pull-request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only addresses the first use case in issue #55.
I don't really understand the second use case: why would you want to allow breaking the min/max/step invariants in this case? I don't see any other situations where it is allowed to break these invariants.
I choose to augment the API to implement this feature by overloading
Thumb::setValuewith a version taking a "push" flag. This might not be the best approach, especially if use case 2 is needed. It might be better to have differently named methods, or to replace the flag with an enum.Please let me know what you think. :)