Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amendment to clarify shell behaviour with apptainer exec. #98

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jkwmoore
Copy link

Description of the Pull Request (PR):

A suggestion for clarification on how the shell will behave when using operators with apptainer exec. I accept this may not be necessary since people should be familiar with how the shell works but this might be helpful.

@jkwmoore jkwmoore force-pushed the shell-operator-clarification branch from c18a0a4 to 75de7f3 Compare May 26, 2022 11:56
Copy link
Contributor

@DrDaveD DrDaveD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for being willing to contribute to the documentation, but I don't think that this is a good place for the information.

I think a better place would be at the end of the "Working with Files" section further down on that page, after where it talks about pipes and redirects working normally. Rather than making it a warning, it could just be in the regular text and say to not expect that complex command lines will all be passed to {command} since the shell will first apply its normal parsing rules. You could also give an example of quoting that shows how to pass a command line with && to {command}.

Come to think of it, that last piece in that section about pipes and redirects is more about the shell than about Files. I would add a new section header before that "Working with the Shell" when you add this new information.

@DrDaveD
Copy link
Contributor

DrDaveD commented Feb 16, 2023

Are you interested in updating this as I requested?

@jkwmoore
Copy link
Author

Unfortunately this one is a bit on my back-burner as this isn't part of my day job. I'll plan on contributing at when I have a bit of contiguous free time booked since I'll need to re-read around the page / fit it into the bulk.

I am thinking I can probably get to this at some point mid next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants