-
Notifications
You must be signed in to change notification settings - Fork 120
Update Spring Boot on Liberty Stack to base on Open Liberty stack. #760
Conversation
Signed-off-by: Scott Kurz <[email protected]>
Upgrade to 20.0.0.3; fix init bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Had a chat with Ozzy and agreed that this seemed to fit best for now as its own stack rather than expanding the capability of the java-openliberty stack.
The fact that the stack parent POM requires its own SpringBoot-maven parent certainly doesn't lend well to the more superficially obvious approach of using a template within the java-openliberty stack.
If you take the two stacks as complete, finished entities it would seem like appsody should be expanded to include both in one stack...somehow. However, given that the Champ role will be further customizing each uniquely in their own shop... it starts to seem more legitimate to have this just be its own stack at least for now.
@BarDweller When I pulled this down to test it, I got a build failure during |
I'll have a look at this today.. it was working locally.. it's possible that I already have something in place that causes it to avoid the issue. |
Signed-off-by: Scott Kurz <[email protected]>
Skip tests in parent install via validate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We caught a mistake here in appsody test
: #790 .. fixing it now:
Sent you: BarDweller#3 |
Closing due to inactivity. Please re-open the PR if this is still something we want to add. |
Checklist:
Read the Code of Conduct and Contributing Guidelines.
Followed the commit message guidelines.
Stack adheres to Appsody stack structure.
Modifying an existing stack:
stack.yaml
Rebase of the stack from the Microprofile stack to the Open Liberty stack.
This required switching from a jar based deploy, to a war based to allow use of the Open Liberty stack dev mode. As a breaking change, the minor version of this stack bumps from 0.1 to 0.2.
Stack remains experimental for now.