Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

Update Spring Boot on Liberty Stack to base on Open Liberty stack. #760

Closed
wants to merge 6 commits into from

Conversation

BarDweller
Copy link
Contributor

Checklist:

Modifying an existing stack:

  • Updated the stack version in stack.yaml

Rebase of the stack from the Microprofile stack to the Open Liberty stack.

This required switching from a jar based deploy, to a war based to allow use of the Open Liberty stack dev mode. As a breaking change, the minor version of this stack bumps from 0.1 to 0.2.

Stack remains experimental for now.

scottkurz
scottkurz previously approved these changes Apr 14, 2020
Copy link
Contributor

@scottkurz scottkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Had a chat with Ozzy and agreed that this seemed to fit best for now as its own stack rather than expanding the capability of the java-openliberty stack.

The fact that the stack parent POM requires its own SpringBoot-maven parent certainly doesn't lend well to the more superficially obvious approach of using a template within the java-openliberty stack.

If you take the two stacks as complete, finished entities it would seem like appsody should be expanded to include both in one stack...somehow. However, given that the Champ role will be further customizing each uniquely in their own shop... it starts to seem more legitimate to have this just be its own stack at least for now.

@skoh7645 skoh7645 added the stack/java-spring-boot2-liberty Issues related to java-spring-boot2-liberty stack label Apr 16, 2020
@skoh7645
Copy link
Collaborator

@BarDweller When I pulled this down to test it, I got a build failure during appsody run:
Screenshot 2020-04-16 at 14 28 44
I noticed there is a similar build failure in the travis build for appsody test even though the build passed, see here.

@BarDweller
Copy link
Contributor Author

I'll have a look at this today.. it was working locally.. it's possible that I already have something in place that causes it to avoid the issue.

scottkurz and others added 2 commits April 16, 2020 12:02
Skip tests in parent install via validate
Copy link
Contributor

@scottkurz scottkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We caught a mistake here in appsody test: #790 .. fixing it now:

@scottkurz
Copy link
Contributor

We caught a mistake here in appsody test: #790 .. fixing it now:

Sent you: BarDweller#3

@neeraj-laad
Copy link
Contributor

Closing due to inactivity. Please re-open the PR if this is still something we want to add.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stack/java-spring-boot2-liberty Issues related to java-spring-boot2-liberty stack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants