704 document quick start removal #728
Conversation
uberskigeek
force-pushed
the
704-document-quick-start-removal
branch
from
93d9097
to
96ef4ec
Compare
|
fixes #704 |
| @@ -44,6 +44,11 @@ OpenAPI endpoints: | |||
| - http://localhost:9080/openapi (the RESTful APIs of the inventory service) | |||
| - http://localhost:9080/openapi/ui (Swagger UI of the deployed APIs) | |||
|
|
|||
| ### Quick start security | |||
There was a problem hiding this comment.
This is good.. but did you look at the java-openliberty stack ? Worth using the same doc? (Not saying that one's better).
| @@ -23,6 +23,7 @@ RUN cd /project/user-app && mvn -B liberty:install-server | |||
| # Remove quick-start-security.xml since it is only needed during local development. | |||
| COPY ./user-app/src /project/user-app/src | |||
| RUN cd /project/user-app && \ | |||
| echo "QUICK START SECURITY IS NOT SECURE FOR PRODUCTION ENVIRONMENTS. IT IS BEING REMOVED" \ | |||
There was a problem hiding this comment.
Should we add this too to java-openliberty ?
There was a problem hiding this comment.
Ok I'll add it there.
uberskigeek
force-pushed
the
704-document-quick-start-removal
branch
from
96ef4ec
to
9b379a8
Compare
skoh7645
requested review from
BarDweller,
neeraj-laad and
Emily-Jiang
and removed request for
BarDweller
| **src/main/liberty/config/configDropins/defaults/quick-start-security.xml**. | ||
|
|
||
| In order to lock down the production image built via `appsody build` this file is deleted during the Docker build of your application production image. (The same file would be deleted if you happened to create your own file at this location as well). | ||
|
|
There was a problem hiding this comment.
An instruction should be provided on how to provide userid and password to access the metrics endpoint.
There was a problem hiding this comment.
This will be addressed by #750
scottkurz
added
the
stack/java-openliberty
|
@skoh7645 @Kamran64 we have one more when you get a chance. This would be: java-microprofile:
java-openliberty:
Thank you again. |
|
@uberskigeek @scottkurz This PR LGTM, but we need to split this PR to do releases for both the |
uberskigeek
force-pushed
the
704-document-quick-start-removal
branch
from
cbff7a8
to
0c2b6eb
Compare
uberskigeek
force-pushed
the
704-document-quick-start-removal
branch
from
0c2b6eb
to
605be40
Compare
|
Split changes to Java-openliberty stack into separate pull request #759 |
Checklist:
Read the Code of Conduct and Contributing Guidelines.
Followed the commit message guidelines.
Stack adheres to Appsody stack structure.
Modifying an existing stack:
stack.yamlContributing a new stack:
Describe how application dependencies are managed:
Explain how Appsody file watcher is utilized:
Describe other Appsody environment variables defined by the stack image:
Describe any limitations and known issues:
Related Issues: