Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14/10 Daily Promotion #36850

Merged
merged 2 commits into from
Oct 14, 2024
Merged

14/10 Daily Promotion #36850

merged 2 commits into from
Oct 14, 2024

Commits on Oct 11, 2024

  1. feat: show chat description (#36805)

    ## Description
    
    [Figma](https://www.figma.com/design/mVEbXXryqv2oBxMcNg8yjC/Concepts-%2B-First-Demo?node-id=295-1720&node-type=section&m=dev)
    
    
    Fixes #36803  
    
    > [!WARNING]  
    > _If no issue exists, please create an issue first, and check with the
    maintainers if the issue is valid._
    
    ## Automation
    
    /ok-to-test tags="@tag.Sanity"
    
    ### 🔍 Cypress test results
    <!-- This is an auto-generated comment: Cypress test results  -->
    > [!TIP]
    > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
    > Workflow run:
    <https://github.com/appsmithorg/appsmith/actions/runs/11289139519>
    > Commit: 8ddc4fd
    > <a
    href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11289139519&attempt=1"
    target="_blank">Cypress dashboard</a>.
    > Tags: `@tag.Sanity`
    > Spec:
    > <hr>Fri, 11 Oct 2024 09:19:15 UTC
    <!-- end of auto-generated comment: Cypress test results  -->
    
    
    ## Communication
    Should the DevRel and Marketing teams inform users about this change?
    - [ ] Yes
    - [ ] No
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    ## Summary by CodeRabbit
    
    - **New Features**
    - Introduced a chat description modal in the AI chat component, allowing
    users to view additional information about the chat.
    - Added a button to open the chat description modal alongside the chat
    title.
    - Enhanced the `WDSAIChatWidget` to accept and display the chat
    description.
    
    - **Bug Fixes**
    - Improved layout adjustments for better responsiveness in the chat
    interface.
    
    - **Documentation**
    - Enhanced export capabilities for easier access to chat description
    modal components and types.
    
    - **Style**
    - Updated CSS styles for improved layout and flexibility in spacing
    across various components.
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    znamenskii-ilia authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    7644b67 View commit details
    Browse the repository at this point in the history
  2. fix: Improve conditional rendering in ChartWidget (#36806)

    ## Description
    Simplify the conditional rendering logic in the ChartWidget component by
    separating the cases for an empty chart and loading state. This improves
    readability and maintainability of the code.
    
    
    Fixes #36213
    _or_  
    Fixes `Issue URL`
    > [!WARNING]  
    > _If no issue exists, please create an issue first, and check with the
    maintainers if the issue is valid._
    
    ## Automation
    
    /ok-to-test tags="@tag.Chart"
    
    ### 🔍 Cypress test results
    <!-- This is an auto-generated comment: Cypress test results  -->
    > [!TIP]
    > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
    > Workflow run:
    <https://github.com/appsmithorg/appsmith/actions/runs/11288506543>
    > Commit: 09b7635
    > <a
    href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11288506543&attempt=1"
    target="_blank">Cypress dashboard</a>.
    > Tags: `@tag.Chart`
    > Spec:
    > <hr>Fri, 11 Oct 2024 08:17:45 UTC
    <!-- end of auto-generated comment: Cypress test results  -->
    
    
    ## Communication
    Should the DevRel and Marketing teams inform users about this change?
    - [ ] Yes
    - [x] No
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    - **New Features**
    - Enhanced the `ChartWidget` component for improved control flow and
    readability.
    - Introduced a streamlined rendering process for different chart states
    (loading, empty, error).
    - Added an optional `onDataPointClick` property to the
    `ChartWidgetProps` interface.
    
    - **Improvements**
    	- Modularized rendering logic for better maintainability.
    - Added a comprehensive set of unit tests for the `ChartWidget`
    component to ensure consistent rendering behavior across various states.
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    rahulbarwal authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    ef5a253 View commit details
    Browse the repository at this point in the history