Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11/10 - Daily Promotion #36833

Merged
merged 10 commits into from
Oct 11, 2024
Merged

11/10 - Daily Promotion #36833

merged 10 commits into from
Oct 11, 2024

Commits on Oct 10, 2024

  1. Configuration menu
    Copy the full SHA
    b16aaaf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9a63c91 View commit details
    Browse the repository at this point in the history
  3. feat: Updated GraphQL form UI (#36728)

    ## Description
    
    This PR has following new features and fixes
    1. Feat: Update GraphQL to use form control dynamic text field instead
    of custom implementation.
    2. Feat: Added full width support for section component in action form.
    3. Fix: Rest API headers not scrollable if there are more number of
    items.
    
    EE PR: appsmithorg/appsmith-ee#5297
    
    Fixes #35494
    Fixes #36410
    Fixes #36499
    
    
    ## Automation
    
    /ok-to-test tags="@tag.All"
    
    ### 🔍 Cypress test results
    <!-- This is an auto-generated comment: Cypress test results  -->
    > [!TIP]
    > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
    > Workflow run:
    <https://github.com/appsmithorg/appsmith/actions/runs/11240771681>
    > Commit: 14b3e00
    > <a
    href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11240771681&attempt=2"
    target="_blank">Cypress dashboard</a>.
    > Tags: `@tag.All`
    > Spec:
    > <hr>Wed, 09 Oct 2024 05:42:42 UTC
    <!-- end of auto-generated comment: Cypress test results  -->
    
    
    ## Communication
    Should the DevRel and Marketing teams inform users about this change?
    - [ ] Yes
    - [x] No
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    ## Release Notes
    
    - **New Features**
    - Introduced a streamlined form-based design for the `PostBodyData`
    component, enhancing user interaction with dynamic text fields for
    GraphQL queries and variables.
    - Added a new styled component, `MainContainer`, to improve layout
    responsiveness in the `CommonEditorForm`.
    - Enhanced the `Section` component with an optional `isFullWidth`
    property for greater configurability.
    
    - **Bug Fixes**
    - Adjusted the `LoadingContainer` height dynamically to enhance UI
    responsiveness.
    
    - **Style**
    - Updated styles for the `Section` component to support full-width
    expansion when applicable.
    
    - **Removed Features**
    - Deprecated the `QueryEditor` and `VariableEditor` components,
    simplifying the editor interface.
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    albinAppsmith authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    579cb7d View commit details
    Browse the repository at this point in the history
  4. test: hard code date values in Date_column_types_validation_spec (#36759

    )
    
    ## Description
    **Problem**
    In the test spec, date data is fed directly from a file
    `(app/client/cypress/fixtures/tableDateColumnTypes.ts)`, which includes
    specific, static dates. However, the test is designed to handle relative
    dates (e.g., "today" and "tomorrow"). As a result, when the date picker
    opens, it displays a fixed date (e.g., September 2024), while the test
    is attempting to select a date like October 8 (tomorrow’s date), which
    is out of view.
    
    EE PR - appsmithorg/appsmith-ee#5312
    
    
    Fixes #36756
    
    ## Automation
    
    /ok-to-test tags="@tag.Table"
    
    ### 🔍 Cypress test results
    <!-- This is an auto-generated comment: Cypress test results  -->
    > [!TIP]
    > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
    > Workflow run:
    <https://github.com/appsmithorg/appsmith/actions/runs/11270917513>
    > Commit: 9ac8789
    > <a
    href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11270917513&attempt=1"
    target="_blank">Cypress dashboard</a>.
    > Tags: `@tag.Table`
    > Spec:
    > <hr>Thu, 10 Oct 2024 09:53:10 UTC
    <!-- end of auto-generated comment: Cypress test results  -->
    
    
    ## Communication
    Should the DevRel and Marketing teams inform users about this change?
    - [ ] Yes
    - [ ] No
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    
    ## Summary by CodeRabbit
    
    - **Bug Fixes**
    - Enhanced clarity and specificity in end-to-end tests for date column
    validation in the table widget.
    - Updated assertions to directly compare against a specific hardcoded
    date.
    
    - **Refactor**
    - Removed the `getFormattedTomorrowDates` method from the Table class,
    streamlining date formatting functionality.
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    jacquesikot authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9041c48 View commit details
    Browse the repository at this point in the history
  5. fix: remove redundant eval trigger (#36764)

    Fixes #36237
    
    ## Automation
    
    /ok-to-test tags="@tag.All"
    
    ### 🔍 Cypress test results
    <!-- This is an auto-generated comment: Cypress test results  -->
    > [!TIP]
    > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
    > Workflow run:
    <https://github.com/appsmithorg/appsmith/actions/runs/11267830066>
    > Commit: 026ef4e
    > <a
    href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11267830066&attempt=3"
    target="_blank">Cypress dashboard</a>.
    > Tags: `@tag.All`
    > Spec:
    > <hr>Thu, 10 Oct 2024 09:40:31 UTC
    <!-- end of auto-generated comment: Cypress test results  -->
    
    
    ## Communication
    Should the DevRel and Marketing teams inform users about this change?
    - [ ] Yes
    - [x] No
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    
    ## Summary by CodeRabbit
    
    ## Release Notes
    
    - **New Features**
    - Introduced new action types for fetching published page resources,
    enhancing state management during the fetch process.
    - Streamlined the resource-fetching logic in the AppViewer component for
    improved efficiency.
    
    - **Bug Fixes**
    - Updated action handlers to accurately reflect the fetching state for
    published page resources.
    
    - **Refactor**
    - Simplified parameters for several functions related to page setup and
    fetching, promoting better clarity and maintainability.
    
    - **Tests**
    - Adjusted test cases to align with the updated action payload structure
    for fetching published pages.
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    rishabhrathod01 authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    00981e3 View commit details
    Browse the repository at this point in the history
  6. fix: Add inverse dependencies to default response in evaluateAndGener…

    …ateResponse (#36780)
    
    ## Description
    <ins>Problem</ins>
    Table loader was not coming up when relaod was linked to any event other
    than page reload.
    
    <ins>Root cause</ins>
    Upon debugging we found that in one of the paths that generates
    `inverseDependecyMap` the object was always empty(for milliseconds
    only).
    
    It led to table not knowing that the query/api linked is in loading
    state.
    More details here on [slack
    thread](https://theappsmith.slack.com/archives/C05M5CTRHM3/p1728455111179839?thread_ts=1728455103.864849&cid=C05M5CTRHM3)
    
    <ins>Solution</ins>
    This pull request adds the inverse dependencies to the default response
    in the `evaluateAndGenerateResponse` function. It ensures that the
    `dependencies` property in the `defaultResponse` object includes the
    inverse dependencies from the `dataTreeEvaluator`. This change improves
    the accuracy and completeness of the default response.
    
    
    Fixes #36538 
    _or_  
    Fixes `Issue URL`
    > [!WARNING]  
    > _If no issue exists, please create an issue first, and check with the
    maintainers if the issue is valid._
    
    ## Automation
    
    /ok-to-test tags="@tag.All"
    
    ### 🔍 Cypress test results
    <!-- This is an auto-generated comment: Cypress test results  -->
    > [!TIP]
    > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
    > Workflow run:
    <https://github.com/appsmithorg/appsmith/actions/runs/11269940675>
    > Commit: 675e0f2
    > <a
    href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11269940675&attempt=2"
    target="_blank">Cypress dashboard</a>.
    > Tags: `@tag.All`
    > Spec:
    > <hr>Thu, 10 Oct 2024 10:32:29 UTC
    <!-- end of auto-generated comment: Cypress test results  -->
    
    
    ## Communication
    Should the DevRel and Marketing teams inform users about this change?
    - [ ] Yes
    - [x] No
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    
    ## Summary by CodeRabbit
    
    - **New Features**
    - Enhanced evaluation and response generation for widget updates in data
    trees.
    	- Improved dependency mapping in evaluation responses.
    
    - **Bug Fixes**
    - Added tests to ensure correct handling of widget updates and
    dependencies.
    
    - **Refactor**
    - Improved clarity and organization of test cases for better
    maintainability.
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    rahulbarwal authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    cda8131 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fc6ded0 View commit details
    Browse the repository at this point in the history
  8. chore: Adding analytics for run action button click & fixing certain …

    …states for execution (#36800)
    
    ## Description
    
    Adding analytics for run action button click & fixing certain states for
    execution under the modularised flow. This PR combines the events
    RUN_API_CLICK and RUN_QUERY_CLICK to RUN_ACTION_CLICK for the
    modularised flow. It also combines the parameters we pass to these
    events.
    
    Fixes [#36794](#36794)
    
    ## Automation
    
    /ok-to-test tags="@tag.Sanity"
    
    ### 🔍 Cypress test results
    <!-- This is an auto-generated comment: Cypress test results  -->
    > [!TIP]
    > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
    > Workflow run:
    <https://github.com/appsmithorg/appsmith/actions/runs/11273497231>
    > Commit: b21315a
    > <a
    href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11273497231&attempt=2"
    target="_blank">Cypress dashboard</a>.
    > Tags: `@tag.Sanity`
    > Spec:
    > <hr>Thu, 10 Oct 2024 13:09:34 UTC
    <!-- end of auto-generated comment: Cypress test results  -->
    
    
    ## Communication
    Should the DevRel and Marketing teams inform users about this change?
    - [ ] Yes
    - [ ] No
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    - **New Features**
    - Added analytics logging for action execution with the new
    "RUN_ACTION_CLICK" event.
    	- Introduced a new hook for tracking analytics on run actions.
    
    - **Bug Fixes**
    	- Enhanced the context handling in the PluginActionContextProvider.
    
    - **Refactor**
    - Updated the `onRunClick` function in the PluginActionToolbar for
    better encapsulation.
    - Improved the `useHandleRunClick` hook with additional context and
    analytics integration.
    
    - **Documentation**
    	- Updated event tracking system to reflect new and removed event names.
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    ankitakinger authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5fadce5 View commit details
    Browse the repository at this point in the history
  9. feat: add initial assistant message (#36798)

    ## Description
    
    ![image](https://github.com/user-attachments/assets/bb8cf448-6bfe-485a-9e19-d222ae3d8411)
    
    
    
    Fixes #36776  
    
    > [!WARNING]  
    > _If no issue exists, please create an issue first, and check with the
    maintainers if the issue is valid._
    
    ## Automation
    
    /ok-to-test tags="@tag.Sanity"
    
    ### 🔍 Cypress test results
    <!-- This is an auto-generated comment: Cypress test results  -->
    > [!TIP]
    > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
    > Workflow run:
    <https://github.com/appsmithorg/appsmith/actions/runs/11275055683>
    > Commit: a8f1554
    > <a
    href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11275055683&attempt=2"
    target="_blank">Cypress dashboard</a>.
    > Tags: `@tag.Sanity`
    > Spec:
    > <hr>Thu, 10 Oct 2024 14:29:09 UTC
    <!-- end of auto-generated comment: Cypress test results  -->
    
    
    ## Communication
    Should the DevRel and Marketing teams inform users about this change?
    - [ ] Yes
    - [ ] No
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    ## Summary by CodeRabbit
    
    - **New Features**
    - Introduced `AssistantSuggestionButton` for enhanced user interaction
    in the AI chat.
    - Added support for displaying and applying assistant suggestions in
    chat threads.
    	- Implemented an editable array component for managing string pairs.
    - Enhanced configuration options with new properties for initial
    assistant messages and suggestions.
    
    - **Improvements**
    	- Improved state management for dynamic messages in the AI chat widget.
    - Updated rendering logic for conditional display of suggestions in chat
    messages.
    - Added new props to facilitate better interaction and suggestion
    handling in chat components.
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    znamenskii-ilia authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a0814e1 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Configuration menu
    Copy the full SHA
    e03522f View commit details
    Browse the repository at this point in the history