Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve conditional rendering in ChartWidget #36806

Merged
merged 10 commits into from
Oct 11, 2024
Merged

fix: Improve conditional rendering in ChartWidget #36806

merged 10 commits into from
Oct 11, 2024

Commits on Oct 10, 2024

  1. refactor: Improve conditional rendering in ChartWidget 

    Simplify the conditional rendering logic in the ChartWidget component by separating the cases for an empty chart and loading state. This improves readability and maintainability of the code.
    @rahulbarwal
    rahulbarwal committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    12dd9af View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Merge branch 'release' of https://github.com/appsmithorg/appsmith int… 

    …o rahulbarwal/issue36213
    @rahulbarwal
    rahulbarwal committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    97fd509 View commit details
    Browse the repository at this point in the history

  2. refactor: Improve conditional rendering in ChartWidget

    @rahulbarwal
    rahulbarwal committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    2b7813a View commit details
    Browse the repository at this point in the history

  3. Adds ChartWidget rendering unit tests

    @rahulbarwal
    rahulbarwal committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    5727959 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'release' of https://github.com/appsmithorg/appsmith int… 

    …o rahulbarwal/issue36213
    @rahulbarwal
    rahulbarwal committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    26533d6 View commit details
    Browse the repository at this point in the history

  5. refactor: Improve conditional rendering in ChartWidget unit tests

    @rahulbarwal
    rahulbarwal committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    b1db1b6 View commit details
    Browse the repository at this point in the history

  6. refactor: Remove unused snapshot file for ChartWidget unit tests

    @rahulbarwal
    rahulbarwal committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    fc812fd View commit details
    Browse the repository at this point in the history

  7. Removes unnecessary lines

    @rahulbarwal
    rahulbarwal committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    d76fd56 View commit details
    Browse the repository at this point in the history

  8. Refactor ChartWidget unit tests and improve conditional rendering 

    This commit refactors the ChartWidget unit tests by removing unnecessary lines and improving the conditional rendering. It also adds rendering unit tests for the ChartWidget. Additionally, it introduces a new type WidgetError for handling errors in the widget.
    @rahulbarwal
    rahulbarwal committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    fa8f9c3 View commit details
    Browse the repository at this point in the history

  9. Refactor ChartWidget unit tests: Remove unnecessary lines and improve… 

    … conditional rendering
    @rahulbarwal
    rahulbarwal committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    09b7635 View commit details
    Browse the repository at this point in the history