Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed old flags for airgap instances #36609

Merged
merged 19 commits into from
Oct 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
9c009d8
chore: removed occurrences of old flags
AmanAgarwal041 Sep 11, 2024
972c1b9
fix: merge from release
AmanAgarwal041 Sep 25, 2024
c410ba8
Merge branch 'release' of github.com:appsmithorg/appsmith into chore/…
AmanAgarwal041 Sep 26, 2024
1786523
fix: failed test cases with feature flags removal
AmanAgarwal041 Sep 30, 2024
b92a9d0
fix: merge from release
AmanAgarwal041 Sep 30, 2024
63010c6
fix: failed tests
AmanAgarwal041 Sep 30, 2024
92ce628
fix: reduced limited test and other fixed test cases
AmanAgarwal041 Sep 30, 2024
7ffad1b
Merge branch 'release' of github.com:appsmithorg/appsmith into chore/…
AmanAgarwal041 Oct 1, 2024
b956497
fix: reverting limited test file
AmanAgarwal041 Oct 1, 2024
a02168b
fix: test cases
AmanAgarwal041 Oct 2, 2024
c2158d8
Merge branch 'release' of github.com:appsmithorg/appsmith into chore/…
AmanAgarwal041 Oct 2, 2024
2bdc8f5
fix: reverting limited test file
AmanAgarwal041 Oct 2, 2024
1089048
fix: test failure
AmanAgarwal041 Oct 2, 2024
90a54af
Merge branch 'release' of github.com:appsmithorg/appsmith into chore/…
AmanAgarwal041 Oct 2, 2024
19b10cf
fix: cypress fails
AmanAgarwal041 Oct 3, 2024
9461218
Merge branch 'release' of github.com:appsmithorg/appsmith into chore/…
AmanAgarwal041 Oct 3, 2024
b30c9bb
Merge branch 'release' of github.com:appsmithorg/appsmith into chore/…
AmanAgarwal041 Oct 4, 2024
126121f
fix: add new row spec fix
AmanAgarwal041 Oct 4, 2024
bfbf6bb
Merge branch 'release' of github.com:appsmithorg/appsmith into chore/…
AmanAgarwal041 Oct 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions app/client/cypress/e2e/Regression/Apps/CommunityIssues_Spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,10 @@ describe(

it("2. Validate table navigation with Server Side pagination enabled with Default selected row", () => {
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget);
propPane.ExpandIfCollapsedSection("pagination");
agHelper.AssertExistingToggleState("Server side pagination", "true");

propPane.ExpandIfCollapsedSection("rowselection");
propPane
.ValidatePropertyFieldValue("Default selected row", "0")
.then(($selectedRow: any) => {
Expand Down Expand Up @@ -114,6 +116,7 @@ describe(
deployMode.NavigateBacktoEditor();
table.WaitUntilTableLoad(0, 0, "v2");
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget);
propPane.ExpandIfCollapsedSection("pagination");
propPane.TogglePropertyState("Server side pagination", "Off");
deployMode.DeployApp();
table.WaitUntilTableLoad(0, 0, "v2");
Expand All @@ -122,10 +125,12 @@ describe(
deployMode.NavigateBacktoEditor();
table.WaitUntilTableLoad(0, 0, "v2");
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget);
propPane.ExpandIfCollapsedSection("pagination");
propPane.TogglePropertyState("Server side pagination", "On");
});

it("4. Change Default selected row in table and verify", () => {
propPane.ExpandIfCollapsedSection("rowselection");
propPane.UpdatePropertyFieldValue("Default selected row", "1");
deployMode.DeployApp();
table.WaitUntilTableLoad(0, 0, "v2");
Expand All @@ -140,6 +145,7 @@ describe(

it("5. Verify Default search text in table as per 'Default search text' property set + Bug 12228", () => {
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget);
propPane.ExpandIfCollapsedSection("search\\&filters");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Please review the escape characters in 'search\&filters'

It appears you're using an extra backslash in "search\&filters". Ensure this is intentional, as unnecessary escape characters might lead to issues. If the section name is "search&filters", you can write it without the double backslash.

Proposed change:

-propPane.ExpandIfCollapsedSection("search\\&filters");
+propPane.ExpandIfCollapsedSection("search&filters");
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
propPane.ExpandIfCollapsedSection("search\\&filters");
propPane.ExpandIfCollapsedSection("search&filters");

propPane.TypeTextIntoField("Default search text", "Bug");
deployMode.DeployApp();
table.AssertSearchText("Bug");
Expand All @@ -148,6 +154,7 @@ describe(
deployMode.NavigateBacktoEditor();

EditorNavigation.SelectEntityByName("Table1", EntityType.Widget);
propPane.ExpandIfCollapsedSection("search\\&filters");
propPane.TypeTextIntoField("Default search text", "Quest", true, false);

deployMode.DeployApp();
Expand All @@ -157,20 +164,23 @@ describe(
table.WaitUntilTableLoad(0, 0, "v2");

EditorNavigation.SelectEntityByName("Table1", EntityType.Widget);
propPane.ExpandIfCollapsedSection("search\\&filters");
propPane.TypeTextIntoField("Default search text", "Epic"); //Bug 12228 - Searching based on hidden column value should not be allowed
deployMode.DeployApp();
table.AssertSearchText("Epic");
table.WaitForTableEmpty("v2");
deployMode.NavigateBacktoEditor();

EditorNavigation.SelectEntityByName("Table1", EntityType.Widget);
propPane.ExpandIfCollapsedSection("search\\&filters");
propPane.RemoveText("defaultsearchtext");
agHelper.GetNClick(dataSources._refreshIcon, 0, true);
table.WaitUntilTableLoad(0, 0, "v2");
});

it("6. Validate Search table with Client Side Search enabled & disabled & onSearchTextChanged is set", () => {
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget);
propPane.ExpandIfCollapsedSection("search\\&filters");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Confirm the necessity of the escape character in 'search\&filters'

Double-check whether the backslash in "search\&filters" is necessary. Using unnecessary escape characters can cause confusion and potential errors.

Suggested change:

-propPane.ExpandIfCollapsedSection("search\\&filters");
+propPane.ExpandIfCollapsedSection("search&filters");
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
propPane.ExpandIfCollapsedSection("search\\&filters");
propPane.ExpandIfCollapsedSection("search&filters");

agHelper.AssertExistingToggleState("Client side search", "true");

deployMode.DeployApp(locators._widgetInDeployed(draggableWidgets.TABLE));
Expand All @@ -188,6 +198,7 @@ describe(
table.WaitUntilTableLoad(0, 1, "v2");

EditorNavigation.SelectEntityByName("Table1", EntityType.Widget);
propPane.ExpandIfCollapsedSection("search\\&filters");
propPane.TogglePropertyState("Client side search", "Off");

deployMode.DeployApp(locators._widgetInDeployed(draggableWidgets.TABLE));
Expand All @@ -205,6 +216,7 @@ describe(
deployMode.NavigateBacktoEditor();
table.WaitUntilTableLoad(0, 1, "v2");
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget);
propPane.ExpandIfCollapsedSection("search\\&filters");
propPane.TogglePropertyState("Client side search", "On");
propPane.EnterJSContext("onSearchTextChanged", "");
propPane.ToggleJSMode("onSearchTextChanged", false);
Expand All @@ -224,6 +236,7 @@ describe(
deployMode.NavigateBacktoEditor();
table.WaitUntilTableLoad(0, 1, "v2");
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget);
propPane.ExpandIfCollapsedSection("search\\&filters");
propPane.TogglePropertyState("Client side search", "Off");

deployMode.DeployApp(locators._widgetInDeployed(draggableWidgets.TABLE));
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
import { featureFlagIntercept } from "../../../../support/Objects/FeatureFlags";
import {
agHelper,
locators,
entityExplorer,
propPane,
draggableWidgets,
apiPage,
entityItems,
homePage,
assertHelper,
} from "../../../../support/Objects/ObjectsCore";
Expand All @@ -15,12 +10,6 @@ import EditorNavigation, {
} from "../../../../support/Pages/EditorNavigation";

describe("Property Pane Suggestions", { tags: ["@tag.JS"] }, () => {
before(() => {
featureFlagIntercept({
ab_learnability_ease_of_initial_use_enabled: true,
});
});

before(function () {
agHelper.ClearLocalStorageCache();
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@ import EditorNavigation, {

const publish = require("../../../../locators/publishWidgetspage.json");
const testdata = require("../../../../fixtures/testdata.json");
import {
agHelper,
entityExplorer,
} from "../../../../support/Objects/ObjectsCore";
import { agHelper, propPane } from "../../../../support/Objects/ObjectsCore";

describe(
"Binding the Table and input Widget",
Expand All @@ -32,7 +29,7 @@ describe(

it("2. validation of data displayed in input widgets based on sorting", function () {
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget);

propPane.ExpandIfCollapsedSection("rowselection");
cy.testJsontext("defaultselectedrow", "0");
cy.get(".draggable-header").contains("id").click({ force: true });
cy.wait(1000);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const commonlocators = require("../../../../locators/commonlocators.json");
const testdata = require("../../../../fixtures/testdata.json");
import apiPageLocators from "../../../../locators/ApiEditor";
import {
entityExplorer,
apiPage,
deployMode,
propPane,
Expand Down Expand Up @@ -91,6 +90,7 @@ describe(
it("3. Table-Text, Validate Server Side Pagination of Paginate with Total v2 Records Count", function () {
deployMode.NavigateBacktoEditor();
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget);
propPane.ExpandIfCollapsedSection("pagination");
propPane.UpdatePropertyFieldValue("Total Records", "20");
deployMode.DeployApp();
cy.wait("@postExecute");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ describe(

it("2. validation of data displayed in input widgets based on selected row", function () {
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget);
_.propPane.ExpandIfCollapsedSection("rowselection");
cy.testJsontext("defaultselectedrow", "2");
cy.readTableV2dataPublish("2", "0").then((tabData) => {
const tabValue = tabData;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ describe(
cy.readTableV2dataPublish("0", "0").then((tabData) => {
expect(tabData).to.eq("#2");
});
_.propPane.ExpandIfCollapsedSection("search\\&filters");
// Input onsearchtextchanged control
cy.get(".t--property-control-onsearchtextchanged .t--js-toggle")
.first()
Comment on lines 24 to 26
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remember to use locator variables and data- attributes instead of CSS selectors*

As we've learned, using locator variables and data-* attributes enhances the maintainability and reliability of our tests. Relying on plain strings and CSS paths can make the tests brittle and harder to maintain. Let's replace the CSS selectors with appropriate locator variables.

Here's how you might adjust the code:

-cy.get(".t--property-control-onsearchtextchanged .t--js-toggle")
-  .first()
-  .click();
+cy.get(commonlocators.onSearchTextChangedToggle)
+  .click();

If commonlocators.onSearchTextChangedToggle doesn't exist, please consider adding it to your locators file.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
// Input onsearchtextchanged control
cy.get(".t--property-control-onsearchtextchanged .t--js-toggle")
.first()
// Input onsearchtextchanged control
cy.get(commonlocators.onSearchTextChangedToggle)
.click();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ describe(
);
// validation of data displayed in input widgets based on search value set
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget);
Comment on lines 27 to 29
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Time for some homework revisions, students!

Let's improve our test by avoiding the use of cy.wait("@updateLayout"). Instead, we can use Cypress's built-in retry-ability to wait for elements to be in the correct state. Here's an example of how we could rewrite this:

cy.get(".t--property-control-allowsearching input").should('be.visible').click({ force: true });

This way, we're letting Cypress automatically wait for the element to be visible before clicking, which is more reliable than using a fixed wait time.

Also applies to: 33-34

_.propPane.ExpandIfCollapsedSection("search\\&filters");
cy.get(".t--property-control-allowsearching input").click({
force: true,
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ describe(
//Validate Table V2 with API data and then add a column
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget);
propPane.UpdatePropertyFieldValue("Table data", "{{Api1.data}}");
propPane.ExpandIfCollapsedSection("pagination");
cy.CheckWidgetProperties(commonlocators.serverSidePaginationCheckbox);
cy.get(`.t--widget-tablewidgetv2 .page-item`)
.first()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import EditorNavigation, {
const commonlocators = require("../../../../locators/commonlocators.json");
const publish = require("../../../../locators/publishWidgetspage.json");
import {
entityExplorer,
agHelper,
deployMode,
propPane,
Expand Down Expand Up @@ -113,6 +112,7 @@ describe(
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget, {}, [
"Container3",
]);
propPane.ExpandIfCollapsedSection("rowselection");
cy.testJsontext("defaultselectedrow", "2");
cy.wait("@updateLayout");
cy.get(commonlocators.TableV2Row)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import {
entityExplorer,
locators,
agHelper,
propPane,
Expand All @@ -17,6 +16,7 @@ describe(
agHelper.AddDsl("jsonFormDynamicHeightDsl");

EditorNavigation.SelectEntityByName("JSONForm1", EntityType.Widget);
propPane.ExpandIfCollapsedSection("general");
agHelper
.GetWidgetCSSHeight(
locators._widgetInDeployed(draggableWidgets.JSONFORM),
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import OneClickBindingLocator from "../../../../locators/OneClickBindingLocator";
import { featureFlagIntercept } from "../../../../support/Objects/FeatureFlags";
import {
agHelper,
apiPage,
Expand All @@ -23,10 +22,6 @@ describe(
() => {
let datasourceName: string;
before(() => {
featureFlagIntercept({
rollout_js_enabled_one_click_binding_enabled: true,
});

dataSources.CreateDataSource("Postgres");

cy.get("@dsName").then((dsName) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ import {
propPane,
table,
} from "../../../../../support/Objects/ObjectsCore";
import EditorNavigation, {
EntityType,
} from "../../../../../support/Pages/EditorNavigation";
const commonlocators = require("../../../../../locators/commonlocators.json");

describe(
Expand All @@ -16,6 +19,7 @@ describe(

it("1.1. should test that allow Add new row property is present", () => {
cy.openPropertyPane("tablewidgetv2");
propPane.ExpandIfCollapsedSection("addingarow");
cy.get(".t--property-control-allowaddingarow").should("exist");
cy.get(".t--property-control-allowaddingarow input").should("exist");
cy.get(".t--add-new-row").should("not.exist");
Expand Down Expand Up @@ -150,7 +154,12 @@ describe(

it("1.7. should not hide the header section when add new row button is enabled and another header element is disabled", () => {
cy.get(".t--discard-new-row").click({ force: true });
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget);
//disable all header widgets for the table
propPane.ExpandIfCollapsedSection("general");
propPane.ExpandIfCollapsedSection("addingarow");
propPane.ExpandIfCollapsedSection("search\\&filters");
propPane.ExpandIfCollapsedSection("pagination");
[
"Show pagination",
"Allow searching",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const widgetsPage = require("../../../../../locators/Widgets.json");
const commonlocators = require("../../../../../locators/commonlocators.json");
import {
agHelper,
entityExplorer,
propPane,
table,
} from "../../../../../support/Objects/ObjectsCore";
Expand All @@ -26,6 +25,7 @@ describe(

it("1. Check if the selectedRowIndices does not contain 2d array", function () {
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget);
propPane.ExpandIfCollapsedSection("rowselection");
propPane.TogglePropertyState("Enable multi-row selection", "On"); //Enable Multi row select

propPane.UpdatePropertyFieldValue("Default selected rows", "[1]"); //Change the value of default selected row
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ describe(
entityExplorer.DragDropWidgetNVerify("tablewidgetv2", 650, 250);
//propPane.EnterJSContext("Table data", JSON.stringify(this.dataSet.TableInput));
// turn on filtering for the table - it is disabled by default in this PR(#34593)
propPane.ExpandIfCollapsedSection("search\\&filters");
agHelper.GetNClick(".t--property-control-allowfiltering input");
table.AddSampleTableData();
//propPane.EnterJSContext("Table Data", JSON.stringify(this.dataSet.TableInput));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ describe(
it("1. Verify Table Filter for 'empty'", function () {
entityExplorer.DragDropWidgetNVerify("tablewidgetv2", 650, 250);
// turn on filtering for the table - it is disabled by default in this PR(#34593)
propPane.ExpandIfCollapsedSection("search\\&filters");
agHelper.GetNClick(".t--property-control-allowfiltering input");
table.AddSampleTableData();
propPane.UpdatePropertyFieldValue(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Avoid using agHelper.Sleep();—wait for specific conditions instead

In line 22, the code uses:

agHelper.Sleep(2000); //table to filter & records to disappear

Relying on fixed delays can lead to flaky tests because the actual load time may vary. Instead, we should wait for a specific element or condition that indicates the table has finished filtering.

Consider replacing the sleep with a wait for the table to become empty:

table.WaitForTableEmpty("v2");

This ensures the test proceeds only after the table is fully filtered.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ describe(
entityExplorer.DragDropWidgetNVerify("tablewidgetv2", 650, 250);
//propPane.EnterJSContext("Table data", JSON.stringify(this.dataSet.TableInput));
// turn on filtering for the table - it is disabled by default in this PR(#34593)
propPane.ExpandIfCollapsedSection("search\\&filters");
agHelper.GetNClick(".t--property-control-allowfiltering input");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Let's improve selector usage by adopting locator variables

In line 21, you're directly using a CSS selector ".t--property-control-allowfiltering input". To make our tests more robust and maintainable, it's important to use locator variables and leverage data-* attributes for selectors, as highlighted in our coding guidelines. This practice enhances readability and eases future updates to the code.

To implement this improvement, let's define a locator variable using a data-* attribute:

Add the following in your locators file (e.g., locators.js):

export const allowFilteringToggle = '[data-cy="t--property-control-allowfiltering"] input';

Then, update line 21 as shown below:

- agHelper.GetNClick(".t--property-control-allowfiltering input");
+ agHelper.GetNClick(allowFilteringToggle);

table.AddSampleTableData();
//propPane.EnterJSContext("Table Data", JSON.stringify(this.dataSet.TableInput));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ describe(
it("1. Verify Full table data - download csv and download Excel", function () {
entityExplorer.DragDropWidgetNVerify("tablewidgetv2", 650, 250);
// turn on filtering for the table - it is disabled by default in this PR(#34593)
propPane.ExpandIfCollapsedSection("search\\&filters");
agHelper.GetNClick(".t--property-control-allowfiltering input");
table.AddSampleTableData();
propPane.UpdatePropertyFieldValue(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ describe(
before(() => {
entityExplorer.DragDropWidgetNVerify("tablewidgetv2", 650, 250);
// turn on filtering for the table - it is disabled by default in this PR(#34593)
propPane.ExpandIfCollapsedSection("search\\&filters");
agHelper.GetNClick(".t--property-control-allowfiltering input");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remember to use locator variables instead of plain strings for selectors.

In line 32, you've used a plain string selector in agHelper.GetNClick(".t--property-control-allowfiltering input"). It's important to use locator variables for selectors to maintain consistency and ease future updates.

Let's define a locator variable for .t--property-control-allowfiltering input and replace the plain string. This practice enhances code readability and adherence to our coding standards.

propPane.EnterJSContext("Table data", JSON.stringify(data));
assertHelper.AssertNetworkStatus("@updateLayout");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ describe(

it("1. Test multi select column shows when enable Multirowselection is true", function () {
cy.openPropertyPane("tablewidgetv2");
_.propPane.ExpandIfCollapsedSection("rowselection");
cy.get(widgetsPage.toggleEnableMultirowselection)
.first()
.click({ force: true });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ describe(
cy.moveToContentTab();
// Chage deat search text value to "data"
cy.backFromPropertyPanel();
propPane.ExpandIfCollapsedSection("search\\&filters");
cy.testJsontext("defaultsearchtext", "data");
deployMode.DeployApp(locators._widgetInDeployed(draggableWidgets.TABLE));
table.WaitForTableEmpty("v2");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ describe(
cy.get(commonlocators.editPropBackButton).click();
cy.openPropertyPane("tablewidgetv2");
// Confirm if isSortable is true
_.propPane.ExpandIfCollapsedSection("sorting");

cy.get(commonlocators.isSortable).should("be.checked");
// Publish App
_.deployMode.DeployApp();
Expand Down Expand Up @@ -124,6 +126,7 @@ describe(
"Table data",
`{{[{step: 1, task: 1}]}}`,
);
_.propPane.ExpandIfCollapsedSection("search\\&filters");
cy.get(".t--property-control-allowfiltering input").click();
cy.editColumn("step");
cy.get(".t--table-filter-toggle-btn").click();
Expand Down Expand Up @@ -237,6 +240,7 @@ describe(
it("7. should check that adding cyclic dependency in the table doesn't crash the app", () => {
//_.deployMode.NavigateBacktoEditor();
cy.openPropertyPane("tablewidgetv2");
_.propPane.ExpandIfCollapsedSection("rowselection");

cy.updateCodeInput(
".t--property-control-defaultselectedrow",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ describe(
before(() => {
_.entityExplorer.DragDropWidgetNVerify(_.draggableWidgets.TABLE);
// turn on filtering for the table - it is disabled by default in this PR(#34593)
_.propPane.ExpandIfCollapsedSection("search\\&filters");
_.agHelper.GetNClick(".t--property-control-allowfiltering input");
_.propPane.EnterJSContext("Table data", tableData);
cy.editColumn("completed");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ describe(
before(() => {
entityExplorer.DragDropWidgetNVerify(draggableWidgets.TABLE);
// turn on filtering for the table - it is disabled by default in this PR(#34593)
propPane.ExpandIfCollapsedSection("search\\&filters");
agHelper.GetNClick(".t--property-control-allowfiltering input");
propPane.EnterJSContext("Table data", tableData);
cy.editColumn("completed");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ describe(
entityExplorer.DragDropWidgetNVerify(draggableWidgets.TABLE, 300, 300);

// turn on filtering for the table - it is disabled by default in this PR(#34593)
propPane.ExpandIfCollapsedSection("search\\&filters");
agHelper.GetNClick(".t--property-control-allowfiltering input");

// Create SQL data-source
Expand Down
1 change: 0 additions & 1 deletion app/client/cypress/support/Objects/FeatureFlags.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import produce from "immer";

const defaultFlags = {
release_side_by_side_ide_enabled: true,
ab_learnability_discoverability_collapse_all_except_data_enabled: false, // remove this flag from here when it's removed from code
rollout_remove_feature_walkthrough_enabled: false, // remove this flag from here when it's removed from code
};

Expand Down
Loading
Loading