-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: MultiEnv switcher visible in view mode in cloud #32333
Conversation
WalkthroughThe updates involve refining the logic within the Changes
Assessment against linked issues
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
}); | ||
|
||
const isRampAllowed = useSelector((state) => | ||
showProductRamps(RAMP_NAME.MULTIPLE_ENV, true)(state), | ||
); | ||
|
||
if (!isFeatureEnabled && !isRampAllowed) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this check here then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this is another case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But !isFeatureEnabled
check will already pass on top so same check won't be needed here right? Also, if it makes sense, we can actually move the entire condition to the top newly added line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Umm, isFeatureEnabled
in line number 23 is actually getting called inside the isMultiEnvNotPresent
selector function. Both of them have different scopes. It is used to make isMultiEnvNotPresent
false even if multiple environments are present. Eg - cloud, where the feature flag is false but there are multiple envs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh alright. Didn't open the collapsed lines above. Thanks.
Description
Issue with ME switcher showing up in cloud
Fixes #32315
Automation
/ok-to-test tags="@tag.MultiEnv"
🔍 Cypress test results
Important
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8520479330
Commit:
20ae88502963ec88f686ef237d4892886189f088
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉
Summary by CodeRabbit