Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add htmlPageTitle hook and use it in login and sign up pages #24458

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

dhruvikn
Copy link
Contributor

@dhruvikn dhruvikn commented Jun 14, 2023

Description

This is a supportive PR for https://github.com/appsmithorg/appsmith-ee/pull/1606

Please see this comment.

PR fixes following issue(s)

Fixes # (issue number)

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (housekeeping or task changes that don't impact user perception)
  • This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

Summary by CodeRabbit

  • New Features

    • Enhanced the login and signup components with dynamic HTML page titles using the Helmet component.
    • Introduced a utility function for consistent page title management across the application.
  • Improvements

    • Improved user experience and SEO by ensuring page titles reflect the current context during authentication processes.

@dhruvikn dhruvikn self-assigned this Jun 14, 2023
@dhruvikn dhruvikn added Bug Something isn't working Widgets Product This label groups issues related to widgets Branding Product All issues under branding and whitelabelling appsmith ecosystem labels Jun 14, 2023
@github-actions github-actions bot added Enhancement New feature or request and removed Bug Something isn't working labels Jun 14, 2023
@dhruvikn dhruvikn added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Jun 14, 2023
@dhruvikn
Copy link
Contributor Author

/ok-to-test

@dhruvikn dhruvikn requested a review from jsartisan June 14, 2023 09:13
@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5265262818.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 24458.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24458&runId=5265262818_1

@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5265262818.
Commit: ``.
All cypress tests have passed 🎉

1 similar comment
@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5265262818.
Commit: ``.
All cypress tests have passed 🎉

@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5265262818.
Commit: ``.
All cypress tests have passed 🎉

1 similar comment
@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5265262818.
Commit: ``.
All cypress tests have passed 🎉

@dhruvikn dhruvikn added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Jun 14, 2023
@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5265262818.
Commit: ``.
All cypress tests have passed 🎉

@Aishwarya-U-R Aishwarya-U-R merged commit 9f3c24d into release Jun 14, 2023
@Aishwarya-U-R Aishwarya-U-R deleted the fix/remove-appsmith-from-tab-title branch June 14, 2023 15:55
dhruvikn added a commit that referenced this pull request Jun 15, 2023
…24458)

## Description

This is a supportive PR for
https://github.com/appsmithorg/appsmith-ee/pull/1606

Please see [this
comment](https://github.com/appsmithorg/appsmith-ee/pull/1606#issuecomment-1590634326).

#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag

#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

(cherry picked from commit 9f3c24d)
@Nikhil-Nandagopal Nikhil-Nandagopal added Platform Administration Pod Issues related to platform administration & management and removed Widgets Product This label groups issues related to widgets labels Aug 6, 2024
Copy link
Contributor

coderabbitai bot commented Aug 6, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The recent changes enhance the user authentication experience in the application by integrating the Helmet component to manage dynamic HTML page titles in the Login and SignUp components. The useHtmlPageTitle hook was introduced to streamline title management and improve SEO. This modular approach increases code maintainability while preserving existing functionality, ensuring users have a relevant context as they navigate through the login and signup processes.

Changes

File Path Change Summary
app/client/src/ce/pages/UserAuth/Login.tsx Added Helmet for dynamic page title management using useHtmlPageTitle. Maintained existing validation logic.
app/client/src/ce/pages/UserAuth/SignUp.tsx Integrated Helmet for dynamic title management, enhancing usability and SEO without major refactoring.
app/client/src/ce/utils/index.ts Introduced useHtmlPageTitle function to provide a consistent HTML page title across the application.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot removed the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branding Product All issues under branding and whitelabelling appsmith ecosystem Enhancement New feature or request Platform Administration Pod Issues related to platform administration & management Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants