fix: Remove empty space in embed apps when nav is set to sidebar

[dhruvikn]

Description

When the navigation was set to sidebar and you tried to embed the app, the sidebar wouldn't show up but the canvas had some empty left margin. This PR fixes that.

PR fixes following issue(s)

Fixes #23190

Type of change

• Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

• Manual
• Jest
• Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• [] I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• PR is being merged under a feature flag

QA activity:

• Speedbreak features have been covered
• Test plan covers all impacted features and areas of interest
• Test plan has been peer reviewed by project stakeholders and other QA members
• Manually tested functionality on DP
• We had an implementation alignment call with stakeholders post QA Round 2
• Cypress test cases have been added and approved by SDET/manual QA
• Added Test Plan Approved label after Cypress tests were reviewed
• Added Test Plan Approved label after JUnit tests were reviewed

Summary by CodeRabbit

• New Features

  • Enhanced application responsiveness for embedded instances by dynamically adjusting layout based on URL query parameters.
  • Improved sidebar width management in mobile view and embedded applications.

• Bug Fixes

  • Fixed issues related to navigation bar visibility affecting the layout in embedded apps.

[dhruvikn]

Blocked until #23725 is merged.

[dhruvikn]

ADS review is not required. Removing @albinAppsmith and @tanvibhakta as reviewers.

Edit: Wokay. Looks like the GitHub bot didn't like my behavior and has added you folks as reviewers again. Please feel free to ignore this PR.

[dhruvikn]

/build-deploy-preview env=release

[github-actions]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5198964875.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 23971.
recreate: .

[dhruvikn]

/ok-to-test

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5199140047.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 23971.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23971&runId=5199140047_1

[github-actions]

Deploy-Preview-URL: https://appsmith-nfe8p66ix-get-appsmith.vercel.app

[rahulbarwal]

Code changes look 👍 .
But I am not able to login to DP url.

[rahulbarwal]

Tested on DP url, working fine.

[github-actions]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5199140047.
Commit: ``.
All cypress tests have passed 🎉

[laveena-en]

Verified, changes LGTM!

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The recent updates enhance the application's handling of query parameters for embedded contexts, specifically addressing layout issues related to the sidebar navigation. By utilizing the useLocation hook, the app can dynamically adjust its layout based on the presence of certain query parameters, ensuring a more responsive design that eliminates unnecessary sidebar space in embedded mode.

Changes

File(s)	Change Summary
app/client/src/pages/AppViewer/AppPage.tsx	Added logic to access URL query parameters for determining embedded state and sidebar visibility, modifying layout responsiveness accordingly.
app/client/src/utils/hooks/useDynamicAppLayout.tsx	Updated hook to incorporate query parameters for embedded apps, refining layout width calculations based on the presence of navigation elements.

Assessment against linked issues

Objective	Addressed	Explanation
Address sidebar space issue in embedded apps (#23190)	✅

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.