Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add app title in browser tab title when nav is set to side #23066

Merged
merged 5 commits into from
May 15, 2023
Merged

fix: Add app title in browser tab title when nav is set to side #23066

merged 5 commits into from
May 15, 2023

Conversation

dhruvikn
Copy link
Contributor

@dhruvikn dhruvikn commented May 8, 2023

Description

We missed out on updating the browser's tab title when we create the sidebar for app navigation. This PR fixes that.

PR fixes following issue(s)

Fixes #15949

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

@dhruvikn dhruvikn self-assigned this May 8, 2023
@github-actions github-actions bot added A-Force Widgets Product This label groups issues related to widgets Bug Something isn't working Embedding Apps Product Issues related to embedding Needs Triaging Needs attention from maintainers to triage labels May 8, 2023
@dhruvikn
Copy link
Contributor Author

dhruvikn commented May 8, 2023

/build-deploy-preview env=release

@what-the-diff
Copy link

what-the-diff bot commented May 8, 2023

PR Summary

  • Added import for getCurrentPageDescription
    Implemented a new import statement for the getCurrentPageDescription function.
  • Implemented selector in Sidebar component
    Utilized the selector in the Sidebar component to set the page description accordingly.
  • Integrated HtmlTitle into sidebar header
    Imported the HtmlTitle component and used it within the sidebar header, passing the current application name and page description as props.

@github-actions
Copy link

github-actions bot commented May 8, 2023

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4912667793.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 23066.
recreate: .

@dhruvikn dhruvikn mentioned this pull request May 8, 2023
Closed
1 task
@github-actions
Copy link

github-actions bot commented May 8, 2023

Deploy-Preview-URL: https://appsmith-jya0up6pj-get-appsmith.vercel.app

@dhruvikn dhruvikn requested a review from jsartisan May 8, 2023 12:01
jsartisan
jsartisan previously approved these changes May 8, 2023
View reviewed changes
@dhruvikn
Copy link
Contributor Author

dhruvikn commented May 8, 2023

/ok-to-test

@github-actions
Copy link

github-actions bot commented May 8, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4914939382.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 23066.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23066&runId=4914939382_1

@github-actions
Copy link

github-actions bot commented May 8, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4914939382.
Commit: ``.
The following are new failures, please fix them before merging the PR:


    To know the list of identified flaky tests - Refer here

    2 similar comments
    @github-actions
    Copy link

    github-actions bot commented May 8, 2023

    Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4914939382.
    Commit: ``.
    The following are new failures, please fix them before merging the PR:


      To know the list of identified flaky tests - Refer here

      @github-actions
      Copy link

      github-actions bot commented May 9, 2023

      Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4914939382.
      Commit: ``.
      The following are new failures, please fix them before merging the PR:


        To know the list of identified flaky tests - Refer here

        @Aishwarya-U-R
        Copy link
        Contributor

        @dhruvikn - please merge latest & start new run. Cancelling re-rerun since time lag is past 12 hrs.

        @dhruvikn
        Copy link
        Contributor Author

        /ok-to-test

        @dhruvikn
        Copy link
        Contributor Author

        /build-deploy-preview env=release

        @github-actions
        Copy link

        Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4933406009.
        Workflow: Appsmith External Integration Test Workflow.
        Commit: ``.
        PR: 23066.
        Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23066&runId=4933406009_1

        @github-actions
        Copy link

        Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4933407562.
        Workflow: On demand build Docker image and deploy preview.
        skip-tests: ``.
        env: release.
        PR: 23066.
        recreate: .

        @github-actions
        Copy link

        Deploy-Preview-URL: https://appsmith-pnxjs93bl-get-appsmith.vercel.app

        @github-actions
        Copy link

        Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4933406009.
        Commit: ``.
        The following are new failures, please fix them before merging the PR:

        1. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js

        To know the list of identified flaky tests - Refer here

        @chandannkumar
        Copy link

        chandannkumar commented May 10, 2023 •
        edited
        Loading

        Observation: @dhruvikn

        @dhruvikn
        Copy link
        Contributor Author

        @chandannkumar issue has been fixed. Creating a new DP, please check.

        @dhruvikn
        Copy link
        Contributor Author

        /build-deploy-preview env=release

        @github-actions
        Copy link

        Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4936382752.
        Workflow: On demand build Docker image and deploy preview.
        skip-tests: ``.
        env: release.
        PR: 23066.
        recreate: .

        @github-actions
        Copy link

        Deploy-Preview-URL: https://appsmith-9miczt2uf-get-appsmith.vercel.app

        @chandannkumar
        Copy link

        Tested this PR and LGTM

        @dhruvikn
        Copy link
        Contributor Author

        /ok-to-test

        @github-actions
        Copy link

        Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4940479549.
        Workflow: Appsmith External Integration Test Workflow.
        Commit: ``.
        PR: 23066.
        Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23066&runId=4940479549_1

        @dhruvikn
        Copy link
        Contributor Author

        /ok-to-test

        @dhruvikn dhruvikn requested a review from jsartisan May 15, 2023 01:37
        @github-actions
        Copy link

        Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4975586553.
        Workflow: Appsmith External Integration Test Workflow.
        Commit: ``.
        PR: 23066.
        Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23066&runId=4975586553_1

        @github-actions
        Copy link

        Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4975586553.
        Commit: ``.
        The following are new failures, please fix them before merging the PR:

        1. cypress/integration/Regression_TestSuite/ClientSideTests/ActionExecution/Error_handling_spec.js

        2. cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/PropertyPaneSuggestion_spec.ts
        3. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Bind_DatePicker_Text_spec.js
        4. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/NavigateToFeatureValidation_spec.js
        5. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug15056_Spec.ts
        6. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug19893_spec.ts
        7. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
        8. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js
        9. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
        10. cypress/integration/Regression_TestSuite/ClientSideTests/SettingsPane/GeneralSettings_spec.ts
        11. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Datepicker/DatePicker_With_Switch_spec.js
        12. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Form/FormReset_spec.js
        13. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Iframe/Iframe_spec.js
        14. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_Copy_Paste_Delete_spec.js
        15. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_container_spec.js
        16. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Others/IconButton_spec.js
        17. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV1/Table_Column_Resize_spec.js
        18. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/Image_resize_spec.js
        19. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/Pagesize_spec.ts
        20. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_Property_JsonUpdate_spec.js
        21. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_Sorting_spec.js
        22. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_Widget_Copy_Paste_spec.js
        23. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/virtual_row_spec.js
        24. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/WidgetSelection_spec.js
        25. cypress/integration/Regression_TestSuite/ClientSideTests/Workspace/UpdateWorkspaceTests_spec.js
        26. cypress/integration/Regression_TestSuite/ServerSideTests/JsFunctionExecution/PlatformFn_spec.ts
        27. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
        28. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/AddWidgetTableAndBind_spec.js
        29. cypress/integration/SanitySuite/Datasources/DatasourceForm_spec.js
        To know the list of identified flaky tests - Refer here

        @github-actions
        Copy link

        Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4975586553.
        Commit: ``.
        The following are new failures, please fix them before merging the PR:

        1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts

        To know the list of identified flaky tests - Refer here

        @github-actions
        Copy link

        Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4975586553.
        Commit: ``.
        The following are new failures, please fix them before merging the PR:

        1. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js

        To know the list of identified flaky tests - Refer here

        @github-actions
        Copy link

        Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4975586553.
        Commit: ``.
        The following are new failures, please fix them before merging the PR:

        1. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js

        2. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
        3. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
        To know the list of identified flaky tests - Refer here

        @github-actions
        Copy link

        Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4975586553.
        Commit: ``.
        All cypress tests have passed 🎉

        @dhruvikn dhruvikn merged commit f15692a into release May 15, 2023
        @dhruvikn dhruvikn deleted the fix/app-title-missing-with-side-nav branch May 15, 2023 12:44
        @Nikhil-Nandagopal Nikhil-Nandagopal added Artifact Platform Product Issues related to the application platform and removed Widgets Product This label groups issues related to widgets labels Aug 5, 2024
        @coderabbitai coderabbitai
        Copy link
        Contributor

        coderabbitai bot commented Aug 5, 2024 •
        edited
        Loading

        Warning

        Rate limit exceeded

        @Nikhil-Nandagopal has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 46 seconds before requesting another review.

        How to resolve this issue?

        After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

        We recommend that you space out your commits to avoid hitting the rate limit.

        How do rate limits work?

        CodeRabbit enforces hourly rate limits for each developer per organization.

        Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

        Please see our FAQ for further information.

        Commits

        Files that changed from the base of the PR and between e56e353 and bf984a5.

        Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

        Share
        Tips

        Chat

        There are 3 ways to chat with CodeRabbit:

        • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
          • I pushed a fix in commit <commit_id>.
          • Generate unit testing code for this file.
          • Open a follow-up GitHub issue for this discussion.
        • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
          • @coderabbitai generate unit testing code for this file.
          • @coderabbitai modularize this function.
        • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
          • @coderabbitai generate interesting stats about this repository and render them as a table.
          • @coderabbitai show all the console.log statements in this repository.
          • @coderabbitai read src/utils.ts and generate unit testing code.
          • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
          • @coderabbitai help me debug CodeRabbit configuration file.

        Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

        CodeRabbit Commands (invoked as PR comments)

        • @coderabbitai pause to pause the reviews on a PR.
        • @coderabbitai resume to resume the paused reviews.
        • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
        • @coderabbitai full review to do a full review from scratch and review all the files again.
        • @coderabbitai summary to regenerate the summary of the PR.
        • @coderabbitai resolve resolve all the CodeRabbit review comments.
        • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
        • @coderabbitai help to get help.

        Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

        CodeRabbit Configuration File (.coderabbit.yaml)

        • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
        • Please see the configuration documentation for more information.
        • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

        Documentation and Community

        • Visit our Documentation for detailed information on how to use CodeRabbit.
        • Join our Discord Community to get help, request features, and share feedback.
        • Follow us on X/Twitter for updates and announcements.

        @github-actions github-actions bot added App Navigation Issues related to the topbar navigation and configuring it Git Platform Pod Issues related to the git & the app platform UI Building Product Issues related to the UI Building experience Verified When issue is retested post its fixed labels Aug 5, 2024
        @Nikhil-Nandagopal Nikhil-Nandagopal added IDE Pod Issues that new developers face while exploring the IDE and removed Git Platform Pod Issues related to the git & the app platform Artifact Platform Product Issues related to the application platform labels Aug 6, 2024
        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
        Reviewers

        @jsartisan jsartisan jsartisan approved these changes

        Assignees

        @dhruvikn dhruvikn

        Labels
        App Navigation Issues related to the topbar navigation and configuring it Bug Something isn't working Embedding Apps Product Issues related to embedding IDE Pod Issues that new developers face while exploring the IDE Needs Triaging Needs attention from maintainers to triage UI Building Product Issues related to the UI Building experience Verified When issue is retested post its fixed
        Projects
        None yet
        Milestone
        No milestone
        Development

        Successfully merging this pull request may close these issues.

        [Bug]: Browser tab title is generic when the embed query param is true
        5 participants
        @dhruvikn @Aishwarya-U-R @chandannkumar @jsartisan @Nikhil-Nandagopal