fix: Fixed race condition in import application flow #22764

nayan-rafiq · 2023-04-26T17:21:40Z

Description

This PR fixes the import application failure issue due to the race condition.

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
PR is being merged under a feature flag

QA activity:

Test plan has been approved by relevant developers
Test plan has been peer reviewed by QA
Cypress test cases have been added and approved by either SDET or manual QA
Organized project review call with relevant stakeholders after Round 1/2 of QA
Added Test Plan Approved label after reveiwing all Cypress test

nayan-rafiq · 2023-04-26T18:36:43Z

/ok-to-test sha=8a584bf

github-actions · 2023-04-26T18:37:09Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4812191048.
Workflow: Appsmith External Integration Test Workflow.
Commit: 8a584bf.
PR: 22764.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22764&runId=4812191048_1

github-actions · 2023-04-26T20:09:48Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4812191048.
Commit: 8a584bf.
The following are new failures, please fix them before merging the PR:

cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
cypress/integration/SanitySuite/Datasources/Airtable_Basic_Spec.ts

To know the list of identified flaky tests - Refer here

AnaghHegde

Minor nit. Rest LGTM

AnaghHegde · 2023-04-27T06:37:01Z

...r/src/main/java/com/appsmith/server/solutions/ce/ImportExportApplicationServiceCEImplV2.java

+        Mono<Workspace> workspaceMono = workspaceService.findById(
+                workspaceId, isGitSync ? Optional.empty() : Optional.of(workspacePermission.getApplicationCreatePermission())
+        ).cache();
+


Why do we need to cache this? I don't see this being used anywhere else in the flow.

Parthvi12 · 2023-04-27T10:16:18Z

/build-deploy-preview skip-tests=true

github-actions · 2023-04-27T10:16:41Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4818615532.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 22764.
recreate: .

github-actions · 2023-04-27T10:43:35Z

Deploy-Preview-URL: https://ce-22764.dp.appsmith.com

nayan-rafiq · 2023-04-29T17:31:47Z

/ok-to-test sha=090d7ec

github-actions · 2023-04-29T17:32:08Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4839981077.
Workflow: Appsmith External Integration Test Workflow.
Commit: 090d7ec.
PR: 22764.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22764&runId=4839981077_1

github-actions · 2023-04-29T19:03:34Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4839981077.
Commit: 090d7ec.
The following are new failures, please fix them before merging the PR:

cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Widgets_Default_data_validation_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/AllWidgets_Reset_Spec.ts
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/CurrencyInput/CurrencyInput_ShowStepArrows_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Filepicker/FilePicker2_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Image/Image_validation_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/List/ListWidgetParseError.ts
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Modal/Modal_focus_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Others/Divider_spec.js

To know the list of identified flaky tests - Refer here

…ce-condition-in-import

nayan-rafiq · 2023-04-30T17:32:15Z

/ok-to-test sha=e75196d

github-actions · 2023-04-30T17:32:39Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4845578320.
Workflow: Appsmith External Integration Test Workflow.
Commit: e75196d.
PR: 22764.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22764&runId=4845578320_1

github-actions · 2023-04-30T19:01:59Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4845578320.
Commit: e75196d.
The following are new failures, please fix them before merging the PR:

To know the list of identified flaky tests - Refer here

github-actions · 2023-05-01T07:12:30Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4845578320.
Commit: e75196d.
The following are new failures, please fix them before merging the PR:

To know the list of identified flaky tests - Refer here

github-actions · 2023-05-01T16:32:06Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4845578320.
Commit: e75196d.
The following are new failures, please fix them before merging the PR:

To know the list of identified flaky tests - Refer here

…ce-condition-in-import

nayan-rafiq · 2023-05-01T17:18:19Z

/ok-to-test sha=1d9d51b

github-actions · 2023-05-01T17:18:43Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4853224596.
Workflow: Appsmith External Integration Test Workflow.
Commit: 1d9d51b.
PR: 22764.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22764&runId=4853224596_1

AnaghHegde

This is needed for the ImportExport v1 as well right?

github-actions · 2023-05-01T18:54:33Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4853224596.
Commit: 1d9d51b.
The following are new failures, please fix them before merging the PR:

cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js

To know the list of identified flaky tests - Refer here

nayan-rafiq · 2023-05-02T05:40:11Z

This is needed for the ImportExport v1 as well right?

@AnaghHegde no, the v1 is a bit different. It has custom js lib import later in the flow, not in the first.

github-actions · 2023-05-02T05:48:35Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4853224596.
Commit: 1d9d51b.
All cypress tests have passed 🎉

coderabbitai · 2024-08-06T09:55:14Z

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 50 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 09fd519 and 1d9d51b.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

fixed race condition in import application flow

8a584bf

nayan-rafiq self-assigned this Apr 26, 2023

nayan-rafiq requested a review from AnaghHegde April 26, 2023 17:21

github-actions bot added Git Platform Pod Issues related to the git & the app platform Import-Export-App Issues related to importing and exporting apps labels Apr 26, 2023

nayan-rafiq marked this pull request as ready for review April 26, 2023 17:30

nayan-rafiq requested a review from Parthvi12 April 26, 2023 18:34

nayan-rafiq changed the title ~~fixed race condition in import application flow~~ fix: Fixed race condition in import application flow Apr 26, 2023

github-actions bot added the Bug Something isn't working label Apr 26, 2023

nayan-rafiq added the QA Needs QA attention label Apr 26, 2023

AnaghHegde requested changes Apr 27, 2023

View reviewed changes

Parthvi12 previously approved these changes Apr 27, 2023

View reviewed changes

Parthvi12 added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Apr 27, 2023

updated as per PR review

090d7ec

nayan-rafiq dismissed Parthvi12’s stale review via 090d7ec April 29, 2023 17:10

nayan-rafiq requested a review from AnaghHegde April 29, 2023 17:34

Merge branch 'release' of github.com:appsmithorg/appsmith into fix/ra…

e75196d

…ce-condition-in-import

Merge branch 'release' of github.com:appsmithorg/appsmith into fix/ra…

1d9d51b

…ce-condition-in-import

AnaghHegde reviewed May 1, 2023

View reviewed changes

nayan-rafiq requested a review from AnaghHegde May 2, 2023 05:38

AnaghHegde approved these changes May 2, 2023

View reviewed changes

nayan-rafiq merged commit 82c660c into release May 2, 2023

nayan-rafiq deleted the fix/race-condition-in-import branch May 2, 2023 09:34

Nikhil-Nandagopal removed the Git Product Issues related to version control product label Aug 6, 2024

github-actions bot added Git Product Issues related to version control product Verified When issue is retested post its fixed labels Aug 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Fixed race condition in import application flow #22764

fix: Fixed race condition in import application flow #22764

nayan-rafiq commented Apr 26, 2023 •

edited

Loading

nayan-rafiq commented Apr 26, 2023

github-actions bot commented Apr 26, 2023

github-actions bot commented Apr 26, 2023

AnaghHegde left a comment

AnaghHegde Apr 27, 2023

Parthvi12 commented Apr 27, 2023

github-actions bot commented Apr 27, 2023

github-actions bot commented Apr 27, 2023

nayan-rafiq commented Apr 29, 2023

github-actions bot commented Apr 29, 2023

github-actions bot commented Apr 29, 2023

nayan-rafiq commented Apr 30, 2023

github-actions bot commented Apr 30, 2023

github-actions bot commented Apr 30, 2023

github-actions bot commented May 1, 2023

github-actions bot commented May 1, 2023

nayan-rafiq commented May 1, 2023

github-actions bot commented May 1, 2023

AnaghHegde left a comment

github-actions bot commented May 1, 2023

nayan-rafiq commented May 2, 2023

github-actions bot commented May 2, 2023

coderabbitai bot commented Aug 6, 2024 •

edited

Loading

Rate limit exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

fix: Fixed race condition in import application flow #22764

fix: Fixed race condition in import application flow #22764

Conversation

nayan-rafiq commented Apr 26, 2023 • edited Loading

Description

Type of change

How Has This Been Tested?

Test Plan

Issues raised during DP testing

Checklist:

Dev activity

QA activity:

nayan-rafiq commented Apr 26, 2023

github-actions bot commented Apr 26, 2023

github-actions bot commented Apr 26, 2023

AnaghHegde left a comment

Choose a reason for hiding this comment

AnaghHegde Apr 27, 2023

Choose a reason for hiding this comment

Parthvi12 commented Apr 27, 2023

github-actions bot commented Apr 27, 2023

github-actions bot commented Apr 27, 2023

nayan-rafiq commented Apr 29, 2023

github-actions bot commented Apr 29, 2023

github-actions bot commented Apr 29, 2023

nayan-rafiq commented Apr 30, 2023

github-actions bot commented Apr 30, 2023

github-actions bot commented Apr 30, 2023

github-actions bot commented May 1, 2023

github-actions bot commented May 1, 2023

nayan-rafiq commented May 1, 2023

github-actions bot commented May 1, 2023

AnaghHegde left a comment

Choose a reason for hiding this comment

github-actions bot commented May 1, 2023

nayan-rafiq commented May 2, 2023

github-actions bot commented May 2, 2023

coderabbitai bot commented Aug 6, 2024 • edited Loading

Rate limit exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

nayan-rafiq commented Apr 26, 2023 •

edited

Loading

coderabbitai bot commented Aug 6, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)