-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to mark application as forkable #21874
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
37e2de8
wip
akash-codemonk 2e92e0e
Merge branch 'release' of github.com:appsmithorg/appsmith into feat/e…
akash-codemonk 6b35e1c
chore: fixes
akash-codemonk 9c63cc9
chore: fixes
akash-codemonk 44c82e5
chore: stick to single line
akash-codemonk 265fb4d
fix: switch component bug
akash-codemonk e31647c
fix: fork button not shown when non-public
akash-codemonk 9a88eea
chore: add cypress test
akash-codemonk 67122ab
Merge branch 'release' of github.com:appsmithorg/appsmith into feat/e…
akash-codemonk 33cfb74
chore: fix warning
akash-codemonk 43e7474
Merge branch 'release' of github.com:appsmithorg/appsmith into feat/e…
akash-codemonk 6cb5a98
chore: fix cypress import
akash-codemonk 73fcf07
Merge branch 'release' of github.com:appsmithorg/appsmith into feat/e…
akash-codemonk c62952f
chore: fix fork button shown for a moment
akash-codemonk d8ba3f8
chore: remove messages to constants
akash-codemonk 0a308c1
Merge branch 'release' of github.com:appsmithorg/appsmith into feat/e…
akash-codemonk d5d1b7b
chore: update test
akash-codemonk b299a1b
Merge branch 'release' of github.com:appsmithorg/appsmith into feat/e…
akash-codemonk 5229d37
Merge branch 'release' of github.com:appsmithorg/appsmith into feat/e…
akash-codemonk d8cc14a
chore: update tooltip message and remove confirmation modal
akash-codemonk afc7e54
Merge branch 'release' of github.com:appsmithorg/appsmith into feat/e…
akash-codemonk 353d2b3
Merge branch 'release' of github.com:appsmithorg/appsmith into feat/e…
akash-codemonk 5480f3c
fix: add back confirmation modal
akash-codemonk 9595522
Merge branch 'release' of github.com:appsmithorg/appsmith into feat/e…
akash-codemonk 686ae8e
chore: fix test
akash-codemonk 4c133c9
Merge branch 'release' of github.com:appsmithorg/appsmith into feat/e…
akash-codemonk 8c3de83
Merge branch 'release' of github.com:appsmithorg/appsmith into feat/e…
akash-codemonk 05eaf67
feat: update to ads 2.0
akash-codemonk 863e644
chore: fix tests
akash-codemonk 0e74a80
chore: fix tests
akash-codemonk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -65,7 +65,7 @@ describe("Fork application across workspaces", function () { | |
}); | ||
cy.wait(2000); | ||
} | ||
|
||
cy.get("#sidebar").should("be.visible"); | ||
cy.PublishtheApp(); | ||
_.agHelper.Sleep(2000); | ||
cy.get("button:contains('Share')").first().click({ force: true }); | ||
|
@@ -99,8 +99,36 @@ describe("Fork application across workspaces", function () { | |
cy.wait(10000); | ||
cy.get(applicationLocators.forkButton).first().click({ force: true }); | ||
cy.get(homePage.forkAppWorkspaceButton).should("be.visible"); | ||
_.agHelper.GetNClick(_.locators._dialogCloseButton); | ||
cy.LogOut(); | ||
cy.LogintoApp(Cypress.env("USERNAME"), Cypress.env("PASSWORD")); | ||
_.homePage.CreateNewApplication(); | ||
}); | ||
}); | ||
}); | ||
}); | ||
|
||
it("Mark application as forkable", () => { | ||
_.appSettings.OpenAppSettings(); | ||
_.appSettings.GoToEmbedSettings(); | ||
_.embedSettings.ToggleMarkForkable(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we also add test for |
||
|
||
_.inviteModal.OpenShareModal(); | ||
_.homePage.InviteUserToWorkspaceFromApp( | ||
Cypress.env("TESTUSERNAME1"), | ||
"App Viewer", | ||
false, | ||
); | ||
_.inviteModal.CloseModal(); | ||
|
||
_.deployMode.DeployApp(); | ||
cy.url().then((url) => { | ||
forkableAppUrl = url; | ||
cy.LogOut(); | ||
cy.LogintoApp(Cypress.env("TESTUSERNAME1"), Cypress.env("TESTPASSWORD1")); | ||
cy.visit(forkableAppUrl); | ||
|
||
_.agHelper.AssertElementVisible(applicationLocators.forkButton); | ||
}); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add index to
it