chore: fix Onboarding/CreateNewApp flaky test #21347

akash-codemonk · 2023-03-13T03:29:08Z

Description

Test cleanup to remove commands which are not part of the user flow. Have ran the test suite 3 times and it has passed all the time. Not sure about why the 503 happens sometimes

Fixes #21327

Type of change

Chore (housekeeping or task changes that don't impact user perception)

Checklist:

Dev activity

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
PR is being merged under a feature flag

akash-codemonk · 2023-03-13T04:06:24Z

/ok-to-test

github-actions · 2023-03-13T04:06:54Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4401296678.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 21347.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=21347&runId=4401296678_1

akash-codemonk · 2023-03-13T05:48:26Z

/ok-to-test

github-actions · 2023-03-13T05:48:50Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4401820992.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 21347.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=21347&runId=4401820992_1

…onboarding-test

akash-codemonk · 2023-03-13T10:37:43Z

/ok-to-test

github-actions · 2023-03-13T10:38:10Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4403954534.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 21347.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=21347&runId=4403954534_1

github-actions · 2023-03-13T12:00:00Z

The following are new failures, please fix them before merging the PR

cypress/integration/Regression_TestSuite/Application/CommunityIssues_Spec.ts
cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/DatasourcePageLayout_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js

akash-codemonk · 2023-03-13T12:31:38Z

/ok-to-test

github-actions · 2023-03-13T12:32:04Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4404919810.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 21347.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=21347&runId=4404919810_1

…onboarding-test

akash-codemonk · 2023-03-14T09:37:28Z

/ok-to-test

github-actions · 2023-03-14T09:37:58Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4414258959.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 21347.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=21347&runId=4414258959_1

akash-codemonk · 2023-03-14T11:04:43Z

...ent/cypress/integration/Regression_TestSuite/ClientSideTests/Onboarding/CreateNewApp_spec.js

-      _.homePage.CreateNewWorkspace(workspaceName);
-      _.homePage.CreateAppInWorkspace(workspaceName); //Since welcome tour always creates app in 1st workspace available
-      _.homePage.NavigateToHome();
-    });


We aren't really using the workspaceName variable anywhere in the test so have removed this . Removing this also seems to have stopped the 503 errors not sure why though

No, this does not solve the issue. I add the new workspace creation code as a part of script fix - for 503. Tried adding new workspace, creating new application in it & then try to click on welcome tour. This will not/does not solve the 503.

akash-codemonk · 2023-03-14T11:08:00Z

...ent/cypress/integration/Regression_TestSuite/ClientSideTests/Onboarding/CreateNewApp_spec.js

-          .click()
-          .wait(4000);
-      }
-    });


The CloseReconnectDataSourceModal and clicking on the welcomeTour are repeated which are not required to run the test, so have removed them.

This was added since we see the Reconnect modal dialog appearing out of nowhere in this test flow & test failing to click on welcome tour. Removing this also will not solve the 503 issue.

If the reconnect modal does appear then either it is a bug or some issue the fork api on ci. Either ways keeping this is a workaround. I can have a look at it when it happens next time, so far the 4 times we ran it does not seem to have happened.
Yes I don't think it fixes the 503 issue.

Aishwarya-U-R · 2023-03-14T19:39:23Z

/ok-to-test sha=9abd3d2

github-actions · 2023-03-14T19:39:49Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4419574598.
Workflow: Appsmith External Integration Test Workflow.
Commit: 9abd3d2.
PR: 21347.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=21347&runId=4419574598_1

coderabbitai · 2024-08-06T09:04:38Z

Warning

Rate limit exceeded

@Nikhil-Nandagopal has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 25 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between f2e1df7 and 9abd3d2.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

akash-codemonk added 2 commits March 13, 2023 07:41

chore: fix test on ci

8bfde38

chore: duplicate steps

1bb7036

github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Mar 13, 2023

chore: remove duplicate click

b8ba541

Merge branch 'release' of github.com:appsmithorg/appsmith into chore/…

1fc950b

…onboarding-test

akash-codemonk added 2 commits March 14, 2023 12:47

Merge branch 'release' of github.com:appsmithorg/appsmith into chore/…

7426f9f

…onboarding-test

Merge branch 'release' of github.com:appsmithorg/appsmith into chore/…

fda4bf9

…onboarding-test

akash-codemonk commented Mar 14, 2023

View reviewed changes

akash-codemonk requested review from Vijetha-Kaja and Aishwarya-U-R and removed request for Vijetha-Kaja March 14, 2023 11:14

akash-codemonk requested a review from Vijetha-Kaja March 14, 2023 11:14

Merge branch 'release' into chore/onboarding-test

9abd3d2

github-actions bot added the Bug Something isn't working label Mar 14, 2023

Aishwarya-U-R approved these changes Mar 15, 2023

View reviewed changes

Aishwarya-U-R added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Mar 15, 2023

Aishwarya-U-R merged commit 4799d0b into release Mar 15, 2023

Aishwarya-U-R deleted the chore/onboarding-test branch March 15, 2023 02:20

Nikhil-Nandagopal added Onboarding Product Issues related to onboarding new developers and removed IDE Pod Issues that new developers face while exploring the IDE labels Aug 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: fix Onboarding/CreateNewApp flaky test #21347

chore: fix Onboarding/CreateNewApp flaky test #21347

akash-codemonk commented Mar 13, 2023 •

edited

Loading

akash-codemonk commented Mar 13, 2023

github-actions bot commented Mar 13, 2023

akash-codemonk commented Mar 13, 2023

github-actions bot commented Mar 13, 2023

akash-codemonk commented Mar 13, 2023

github-actions bot commented Mar 13, 2023

github-actions bot commented Mar 13, 2023

akash-codemonk commented Mar 13, 2023

github-actions bot commented Mar 13, 2023

akash-codemonk commented Mar 14, 2023

github-actions bot commented Mar 14, 2023

akash-codemonk Mar 14, 2023

Aishwarya-U-R Mar 14, 2023

akash-codemonk Mar 14, 2023

Aishwarya-U-R Mar 14, 2023

akash-codemonk Mar 15, 2023 •

edited

Loading

Aishwarya-U-R commented Mar 14, 2023

github-actions bot commented Mar 14, 2023

coderabbitai bot commented Aug 6, 2024

Rate limit exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

chore: fix Onboarding/CreateNewApp flaky test #21347

chore: fix Onboarding/CreateNewApp flaky test #21347

Conversation

akash-codemonk commented Mar 13, 2023 • edited Loading

Description

Type of change

Checklist:

Dev activity

akash-codemonk commented Mar 13, 2023

github-actions bot commented Mar 13, 2023

akash-codemonk commented Mar 13, 2023

github-actions bot commented Mar 13, 2023

akash-codemonk commented Mar 13, 2023

github-actions bot commented Mar 13, 2023

github-actions bot commented Mar 13, 2023

akash-codemonk commented Mar 13, 2023

github-actions bot commented Mar 13, 2023

akash-codemonk commented Mar 14, 2023

github-actions bot commented Mar 14, 2023

akash-codemonk Mar 14, 2023

Choose a reason for hiding this comment

Aishwarya-U-R Mar 14, 2023

Choose a reason for hiding this comment

akash-codemonk Mar 14, 2023

Choose a reason for hiding this comment

Aishwarya-U-R Mar 14, 2023

Choose a reason for hiding this comment

akash-codemonk Mar 15, 2023 • edited Loading

Choose a reason for hiding this comment

Aishwarya-U-R commented Mar 14, 2023

github-actions bot commented Mar 14, 2023

coderabbitai bot commented Aug 6, 2024

Rate limit exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

akash-codemonk commented Mar 13, 2023 •

edited

Loading

akash-codemonk Mar 15, 2023 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)