fix: welcome page get started button #21183

eco-monk · 2023-03-06T09:17:21Z

Description

Fixes #13093

When disabled, Get started button in welcome page will not redirect on click

Media
https://www.loom.com/share/85755d7e71e64428871a1183d18595ba

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
PR is being merged under a feature flag

QA activity:

Test plan has been approved by relevant developers
Test plan has been peer reviewed by QA
Cypress test cases have been added and approved by either SDET or manual QA
Organized project review call with relevant stakeholders after Round 1/2 of QA
Added Test Plan Approved label after reveiwing all Cypress test

vercel · 2023-03-06T09:17:26Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
appsmith	❌ Failed (Inspect)			Mar 6, 2023 at 9:22AM (UTC)

eco-monk · 2023-03-06T09:17:45Z

/ok-to-test

github-actions · 2023-03-06T09:18:11Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4341789395.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 21183.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=21183&runId=4341789395_1

eco-monk · 2023-03-06T10:37:32Z

/build-deploy-preview

github-actions · 2023-03-06T10:37:58Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4342487901.
Workflow: On demand build Docker image and deploy preview.
PR: 21183.

github-actions · 2023-03-06T10:40:21Z

The following are new failures, please fix them before merging the PR

cypress/integration/Regression_TestSuite/ClientSideTests/FormLogin/EnableFormLogin_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Github/EnableGithub_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Google/EnableGoogle_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/AppPageLayout_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/DatasourcePageLayout_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/WidgetsLayout_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Childwigets/List_Select_Widgets_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Childwigets/Listv2_Button_Widget_spec.js

github-actions · 2023-03-06T11:13:34Z

Deploy-Preview-URL: https://ce-21183.dp.appsmith.com

github-actions · 2023-03-06T16:15:39Z

The following are new failures, please fix them before merging the PR

cypress/integration/Regression_TestSuite/ClientSideTests/FormLogin/EnableFormLogin_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Github/EnableGithub_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Google/EnableGoogle_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/AppPageLayout_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Childwigets/Listv2_Button_Widget_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Childwigets/Listv2_Button_Widget_spec.js

app/client/src/ce/sagas/userSagas.tsx

app/client/src/sagas/ErrorSagas.tsx

github-actions · 2023-03-07T05:10:52Z

The following are new failures, please fix them before merging the PR

cypress/integration/Regression_TestSuite/ClientSideTests/FormLogin/EnableFormLogin_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Github/EnableGithub_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Google/EnableGoogle_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/AppPageLayout_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/DatasourcePageLayout_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/WidgetsLayout_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Childwigets/List_Select_Widgets_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Childwigets/Listv2_Button_Widget_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Childwigets/Listv2_Button_Widget_spec.js

eco-monk · 2023-03-07T12:38:05Z

/ok-to-test

github-actions · 2023-03-07T12:38:29Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4354191344.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 21183.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=21183&runId=4354191344_1

eco-monk · 2023-03-07T13:22:05Z

Note: need to account for redirections specific to EE repo (if any)

eco-monk · 2023-03-08T05:45:42Z

/ok-to-test

github-actions · 2023-03-08T05:46:05Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4361539522.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 21183.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=21183&runId=4361539522_1

…o release

eco-monk · 2023-03-09T11:45:03Z

/ok-to-test

github-actions · 2023-03-09T11:45:30Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4374074776.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 21183.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=21183&runId=4374074776_1

github-actions · 2023-03-09T13:08:12Z

The following are new failures, please fix them before merging the PR

cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
cypress/integration/Regression_TestSuite/UpgradeAppsmith/UpgradeAppsimth_spec.js

eco-monk · 2023-03-10T03:03:56Z

/build-deploy-preview

github-actions · 2023-03-10T03:04:28Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4380912820.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 21183.

github-actions · 2023-03-10T11:36:17Z

Deploy-Preview-URL: https://ce-21183.dp.appsmith.com

Richarex · 2023-03-14T04:59:15Z

Verified this on a local build as the sign up flow is different in DP’s, working as expected. There are few issues with the button widget added in this bug id #406

eco-monk · 2023-03-14T05:06:27Z

Discussion on why DP flow is different:
https://theappsmith.slack.com/archives/CGBPVEJ5C/p1678694313317649

Aishwarya-U-R · 2023-03-14T05:28:42Z

/ci-merge-check

github-actions · 2023-03-14T05:29:07Z

found ci-merge-check 21183

coderabbitai · 2024-08-06T09:04:36Z

Warning

Rate limit exceeded

@Nikhil-Nandagopal has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 28 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 4a99ff5 and 9eafd4b.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

eco-monk added 2 commits March 6, 2023 14:38

get started button fix

8bb9045

clear history stack on sign out by opening in new tab

e655265

github-actions bot added the Bug Something isn't working label Mar 6, 2023

vercel bot had a problem deploying to Preview March 6, 2023 09:22 Failure

eco-monk requested review from hetunandu and akash-codemonk March 6, 2023 09:26

hetunandu requested changes Mar 7, 2023

View reviewed changes

app/client/src/ce/sagas/userSagas.tsx Outdated Show resolved Hide resolved

app/client/src/sagas/ErrorSagas.tsx Outdated Show resolved Hide resolved

use history block to prevent back button on logina nd signup page

71385df

eco-monk requested a review from hetunandu March 7, 2023 12:26

add comments

1c04ee7

remove sign up block, because it signout redirects to login only

9679022

hetunandu previously approved these changes Mar 8, 2023

View reviewed changes

eco-monk added 3 commits March 8, 2023 14:02

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

baa2d09

…o release

Merge branch 'release' into fix/signup-issues

288c4b9

undo history block

9eafd4b

eco-monk dismissed hetunandu’s stale review via 9eafd4b March 9, 2023 11:43

github-actions bot added High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage IDE Pod Issues that new developers face while exploring the IDE Release Welcome Screen Issues related to the welcome screen labels Mar 9, 2023

eco-monk mentioned this pull request Mar 9, 2023

[Bug]: Button widget issues (design-system-old) appsmithorg/design-system#406

Open

1 task

eco-monk requested a review from hetunandu March 10, 2023 02:40

eco-monk changed the title ~~fix: signup issues~~ fix: welcome page get started button Mar 10, 2023

hetunandu approved these changes Mar 10, 2023

View reviewed changes

Richarex added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Mar 14, 2023

Aishwarya-U-R merged commit a9e3745 into release Mar 14, 2023

Aishwarya-U-R deleted the fix/signup-issues branch March 14, 2023 05:33

Nikhil-Nandagopal added Onboarding Product Issues related to onboarding new developers and removed IDE Pod Issues that new developers face while exploring the IDE labels Aug 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: welcome page get started button #21183

fix: welcome page get started button #21183

eco-monk commented Mar 6, 2023 •

edited

Loading

vercel bot commented Mar 6, 2023 •

edited

Loading

eco-monk commented Mar 6, 2023

github-actions bot commented Mar 6, 2023

eco-monk commented Mar 6, 2023

github-actions bot commented Mar 6, 2023

github-actions bot commented Mar 6, 2023

github-actions bot commented Mar 6, 2023

github-actions bot commented Mar 6, 2023

github-actions bot commented Mar 7, 2023

eco-monk commented Mar 7, 2023

github-actions bot commented Mar 7, 2023

eco-monk commented Mar 7, 2023

eco-monk commented Mar 8, 2023

github-actions bot commented Mar 8, 2023

eco-monk commented Mar 9, 2023

github-actions bot commented Mar 9, 2023

github-actions bot commented Mar 9, 2023

eco-monk commented Mar 10, 2023

github-actions bot commented Mar 10, 2023

github-actions bot commented Mar 10, 2023

Richarex commented Mar 14, 2023 •

edited

Loading

eco-monk commented Mar 14, 2023

Aishwarya-U-R commented Mar 14, 2023

github-actions bot commented Mar 14, 2023

coderabbitai bot commented Aug 6, 2024

Rate limit exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

fix: welcome page get started button #21183

fix: welcome page get started button #21183

Conversation

eco-monk commented Mar 6, 2023 • edited Loading

Description

Type of change

How Has This Been Tested?

Test Plan

Issues raised during DP testing

Checklist:

Dev activity

QA activity:

vercel bot commented Mar 6, 2023 • edited Loading

eco-monk commented Mar 6, 2023

github-actions bot commented Mar 6, 2023

eco-monk commented Mar 6, 2023

github-actions bot commented Mar 6, 2023

github-actions bot commented Mar 6, 2023

github-actions bot commented Mar 6, 2023

github-actions bot commented Mar 6, 2023

github-actions bot commented Mar 7, 2023

eco-monk commented Mar 7, 2023

github-actions bot commented Mar 7, 2023

eco-monk commented Mar 7, 2023

eco-monk commented Mar 8, 2023

github-actions bot commented Mar 8, 2023

eco-monk commented Mar 9, 2023

github-actions bot commented Mar 9, 2023

github-actions bot commented Mar 9, 2023

eco-monk commented Mar 10, 2023

github-actions bot commented Mar 10, 2023

github-actions bot commented Mar 10, 2023

Richarex commented Mar 14, 2023 • edited Loading

eco-monk commented Mar 14, 2023

Aishwarya-U-R commented Mar 14, 2023

github-actions bot commented Mar 14, 2023

coderabbitai bot commented Aug 6, 2024

Rate limit exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

eco-monk commented Mar 6, 2023 •

edited

Loading

vercel bot commented Mar 6, 2023 •

edited

Loading

Richarex commented Mar 14, 2023 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)