-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Removed on page load edges from layout model #21038
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
/ok-to-test sha=7c4f6a8 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4292567885. |
LGTM |
The following are new failures, please fix them before merging the PR
|
...ain/java/com/appsmith/server/migrations/db/ce/Migration004ResetOnPageLoadEdgesInLayouts.java
Show resolved
Hide resolved
The following are new failures, please fix them before merging the PR
|
/ok-to-test sha=1d0eeb6 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4303404007. |
The following are new failures, please fix them before merging the PR
|
Warning Rate limit exceeded@Nikhil-Nandagopal has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 8 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Description
Since an Appsmith application is not limited by the number of interconnections it can make, it is possible for users to create graphs so complex that we end up having MBs of data in a relatively simple page as well. This was causing failures in a user's app since they were now unable to update their app any further. We do not really use this property anywhere in our logic today, and this is essentially redundant information. This PR gets rid of the edges property from the layout and runs a migrations to clean up all existing pages as well.
If we do find a need for this property in the future, a simple update layout on each of these pages would do the trick.
Fixes #20680
Type of change
How Has This Been Tested?
Test Plan
Issues raised during DP testing
Checklist:
Dev activity
QA activity: