fix: Brand colors sometimes shows different colors on cloud #19672

jsartisan · 2023-01-10T12:14:00Z

Caches the tenant config so that we don't show the ugly black color

Description

Fixes #19530

Type of change

Bug fix

How Has This Been Tested?

Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
PR is being merged under a feature flag

QA activity:

Test plan has been approved by relevant developers
Test plan has been peer reviewed by QA
Cypress test cases have been added and approved by either SDET or manual QA
Organized project review call with relevant stakeholders after Round 1/2 of QA
Added Test Plan Approved label after reveiwing all Cypress test

vercel · 2023-01-10T12:14:04Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
appsmith	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 1, 2023 at 6:37AM (UTC)

keyurparalkar

Are we using multi-tenant Architecture to manage branding of each company? if yes how are we cache if multiple tenants are present in a single browser session? For example, Two tenants: ABC and XYZ have different branding configs, then how are we caching these configs in local storage.
I think in that scenario we should cache tenantConfig based on each tenant.

keyurparalkar · 2023-01-11T07:51:44Z

app/client/src/ce/selectors/tenantSelectors.tsx

+  const cachedTenantConfig = localStorage.getItem("tenantConfig");
+  let cachedTenantConfigParsed = {
+    brandColors: {
+      ...createBrandColorsFromPrimaryColor("#000"),


Lets move this color to a constant

keyurparalkar · 2023-01-11T07:52:53Z

app/client/src/ce/selectors/tenantSelectors.tsx

+    if (cachedTenantConfig) {
+      cachedTenantConfigParsed = JSON.parse(cachedTenantConfig);
+    }
+  } catch (e) {}


Rather than a blank catch block, can we use log.debug to log any errors that occur

keyurparalkar · 2023-01-11T07:57:03Z

app/client/src/ce/selectors/tenantSelectors.tsx

+  return {
+    ...cachedTenantConfigParsed,
+    ...(state.tenant?.tenantConfiguration || {}),
+  } as Record<string, any>;


Remove the as keyword, We can instead provide the return type in the function definition.

keyurparalkar · 2023-01-11T09:09:21Z

app/client/src/ce/reducers/tenantReducer.ts

 export const initialState: TenantReduxState<any> = {
  userPermissions: [],
-  tenantConfiguration: {
-    brandColors: {


Since earlier we were setting the initial state with some value, why are we replacing it with the blank object?

Yes because the logic for setting default values is now moved to the selector instead of the reducer.

…cache-branding-values

jsartisan · 2023-01-26T07:44:43Z

/ok-to-test sha=0986124

github-actions · 2023-01-26T07:45:09Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4013203840.
Workflow: Appsmith External Integration Test Workflow.
Commit: 0986124.
PR: 19672.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19672&runId=4013203840_1

github-actions · 2023-01-26T13:23:10Z

The following are new failures, please fix them before merging the PR

github-actions · 2023-01-26T13:23:11Z

The following are new failures, please fix them before merging the PR cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_To_App_spec.js

jsartisan · 2023-01-31T05:33:09Z

/ok-to-test=b8b2b80

jsartisan · 2023-01-31T06:22:37Z

/ok-to-test sha=b8b2b80

github-actions · 2023-01-31T06:23:05Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4051368563.
Workflow: Appsmith External Integration Test Workflow.
Commit: b8b2b80.
PR: 19672.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19672&runId=4051368563_1

github-actions · 2023-01-31T07:29:12Z

The following are new failures, please fix them before merging the PR

github-actions · 2023-01-31T07:29:14Z

The following are new failures, please fix them before merging the PR cypress/integration/Regression_TestSuite/Application/PromisesApp_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Linting/BasicLint_spec.ts
cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad_cyclic_dependency_errors_spec.js

github-actions · 2023-01-31T09:28:37Z

The following are new failures, please fix them before merging the PR

github-actions · 2023-01-31T09:28:38Z

The following are new failures, please fix them before merging the PR cypress/integration/Regression_TestSuite/ClientSideTests/Linting/BasicLint_spec.ts
cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad_cyclic_dependency_errors_spec.js
cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad_cyclic_dependency_errors_spec.js

github-actions · 2023-01-31T10:55:38Z

The following are new failures, please fix them before merging the PR

github-actions · 2023-01-31T10:55:39Z

The following are new failures, please fix them before merging the PR cypress/integration/Regression_TestSuite/ClientSideTests/Linting/BasicLint_spec.ts
cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad_cyclic_dependency_errors_spec.js
cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad_cyclic_dependency_errors_spec.js

…cache-branding-values

jsartisan · 2023-02-01T06:34:55Z

/ok-to-test sha=fb2d586

github-actions · 2023-02-01T06:35:19Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4061641296.
Workflow: Appsmith External Integration Test Workflow.
Commit: fb2d586.
PR: 19672.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19672&runId=4061641296_1

github-actions · 2023-02-01T07:42:34Z

The following are new failures, please fix them before merging the PR

github-actions · 2023-02-01T07:42:35Z

The following are new failures, please fix them before merging the PR cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js

coderabbitai · 2024-08-06T07:48:17Z

Warning

Rate limit exceeded

@Nikhil-Nandagopal has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 28 minutes and 46 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 7ca4f73 and fb2d586.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

cache tenant config

4b34c18

jsartisan requested a review from keyurparalkar January 10, 2023 12:15

vercel bot deployed to Preview January 10, 2023 12:17 View deployment

refactor code

30798bf

github-actions bot added the Bug Something isn't working label Jan 11, 2023

update logo url

5d996ea

vercel bot deployed to Preview January 11, 2023 08:15 View deployment

keyurparalkar reviewed Jan 11, 2023

View reviewed changes

refactor

5f275bc

vercel bot deployed to Preview January 11, 2023 10:44 View deployment

code review feedback fixes

0201116

jsartisan requested a review from keyurparalkar January 11, 2023 10:54

vercel bot deployed to Preview January 11, 2023 11:01 View deployment

Merge branch 'release' of github.com:appsmithorg/appsmith into chore/…

c5fd014

…cache-branding-values

keyurparalkar previously approved these changes Jan 12, 2023

View reviewed changes

update ce logic

a435f1f

jsartisan dismissed keyurparalkar’s stale review via a435f1f January 16, 2023 12:17

remove unused import

e705893

vercel bot deployed to Preview January 16, 2023 12:31 View deployment

fix reducer bug

079e3c4

vercel bot deployed to Preview January 17, 2023 06:08 View deployment

jsartisan added 2 commits January 23, 2023 11:08

export default branding config

1a47891

Merge branch 'release' of github.com:appsmithorg/appsmith into chore/…

93151de

…cache-branding-values

vercel bot deployed to Preview January 23, 2023 05:46 View deployment

fix merge conflicts

b8b2b80

vercel bot deployed to Preview January 31, 2023 05:40 View deployment

Merge branch 'release' of github.com:appsmithorg/appsmith into chore/…

fb2d586

…cache-branding-values

vercel bot deployed to Preview February 1, 2023 06:37 View deployment

dilippitchika self-requested a review February 2, 2023 06:09

dilippitchika approved these changes Feb 2, 2023

View reviewed changes

jsartisan merged commit b314bd7 into release Feb 2, 2023

jsartisan deleted the chore/cache-branding-values branch February 2, 2023 06:13

jsartisan restored the chore/cache-branding-values branch February 7, 2023 07:05

Nikhil-Nandagopal added Platform Administration Pod Issues related to platform administration & management and removed Widgets Product This label groups issues related to widgets labels Aug 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Brand colors sometimes shows different colors on cloud #19672

fix: Brand colors sometimes shows different colors on cloud #19672

jsartisan commented Jan 10, 2023

vercel bot commented Jan 10, 2023 •

edited

Loading

keyurparalkar left a comment

keyurparalkar Jan 11, 2023

keyurparalkar Jan 11, 2023

keyurparalkar Jan 11, 2023

jsartisan Jan 11, 2023

keyurparalkar Jan 11, 2023

jsartisan Jan 11, 2023

jsartisan commented Jan 26, 2023

github-actions bot commented Jan 26, 2023

github-actions bot commented Jan 26, 2023

github-actions bot commented Jan 26, 2023

jsartisan commented Jan 31, 2023

jsartisan commented Jan 31, 2023

github-actions bot commented Jan 31, 2023

github-actions bot commented Jan 31, 2023

github-actions bot commented Jan 31, 2023

github-actions bot commented Jan 31, 2023

github-actions bot commented Jan 31, 2023

github-actions bot commented Jan 31, 2023

github-actions bot commented Jan 31, 2023

jsartisan commented Feb 1, 2023

github-actions bot commented Feb 1, 2023

github-actions bot commented Feb 1, 2023

github-actions bot commented Feb 1, 2023

coderabbitai bot commented Aug 6, 2024

Rate limit exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

fix: Brand colors sometimes shows different colors on cloud #19672

fix: Brand colors sometimes shows different colors on cloud #19672

Conversation

jsartisan commented Jan 10, 2023

Description

Type of change

How Has This Been Tested?

Test Plan

Issues raised during DP testing

Checklist:

Dev activity

QA activity:

vercel bot commented Jan 10, 2023 • edited Loading

keyurparalkar left a comment

Choose a reason for hiding this comment

keyurparalkar Jan 11, 2023

Choose a reason for hiding this comment

keyurparalkar Jan 11, 2023

Choose a reason for hiding this comment

keyurparalkar Jan 11, 2023

Choose a reason for hiding this comment

jsartisan Jan 11, 2023

Choose a reason for hiding this comment

keyurparalkar Jan 11, 2023

Choose a reason for hiding this comment

jsartisan Jan 11, 2023

Choose a reason for hiding this comment

jsartisan commented Jan 26, 2023

github-actions bot commented Jan 26, 2023

github-actions bot commented Jan 26, 2023

github-actions bot commented Jan 26, 2023

jsartisan commented Jan 31, 2023

jsartisan commented Jan 31, 2023

github-actions bot commented Jan 31, 2023

github-actions bot commented Jan 31, 2023

github-actions bot commented Jan 31, 2023

github-actions bot commented Jan 31, 2023

github-actions bot commented Jan 31, 2023

github-actions bot commented Jan 31, 2023

github-actions bot commented Jan 31, 2023

jsartisan commented Feb 1, 2023

github-actions bot commented Feb 1, 2023

github-actions bot commented Feb 1, 2023

github-actions bot commented Feb 1, 2023

coderabbitai bot commented Aug 6, 2024

Rate limit exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

vercel bot commented Jan 10, 2023 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)